Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

docs: add zh docs #70

Merged
merged 8 commits into from
Dec 18, 2021
Merged

docs: add zh docs #70

merged 8 commits into from
Dec 18, 2021

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Apr 25, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member Author

@Mister-Hope Mister-Hope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by myself, no typos found.

Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Could you leave formatting to another PR?

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Apr 26, 2020

Thanks a lot. Could you leave formatting to another PR?

Yes, and BTW, you mixed 120 wrap and no wrap in the English docs, how should I fomat them?

If I use wrap in Chinese docs, there will be an extra spacing.So i am not wrapping them

@Mister-Hope
Copy link
Member Author

This PR only adds zh docs now

Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't finished the review yet. There're some sentences or words looks like generate from Google Translation.

Nevertheless, thanks you for your effort.

@Mister-Hope
Copy link
Member Author

By the way, I made a fix for the navbar dropdown issue in 1.4. As now it's not fixed in the newest version, shall we review the PR and publish a new version to fix i?

@netlify
Copy link

netlify bot commented Dec 18, 2021

✔️ Deploy Preview for friendly-johnson-165541 ready!

🔨 Explore the source changes: 801bfd5

🔍 Inspect the deploy log: https://app.netlify.com/sites/friendly-johnson-165541/deploys/61be3e4eb2d68300072ef4ce

😎 Browse the preview: https://deploy-preview-70--friendly-johnson-165541.netlify.app

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

@ulivz ulivz merged commit 0a3449a into vuepress:master Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants