-
-
Notifications
You must be signed in to change notification settings - Fork 64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed by myself, no typos found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Could you leave formatting to another PR?
Yes, and BTW, you mixed 120 wrap and no wrap in the English docs, how should I fomat them? If I use wrap in Chinese docs, there will be an extra spacing.So i am not wrapping them |
This PR only adds zh docs now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't finished the review yet. There're some sentences or words looks like generate from Google Translation.
Nevertheless, thanks you for your effort.
By the way, I made a fix for the navbar dropdown issue in 1.4. As now it's not fixed in the newest version, shall we review the PR and publish a new version to fix i? |
Co-authored-by: Billyyyyy3320 <[email protected]>
✔️ Deploy Preview for friendly-johnson-165541 ready! 🔨 Explore the source changes: 801bfd5 🔍 Inspect the deploy log: https://app.netlify.com/sites/friendly-johnson-165541/deploys/61be3e4eb2d68300072ef4ce 😎 Browse the preview: https://deploy-preview-70--friendly-johnson-165541.netlify.app |
Co-authored-by: Billyyyyy3320 <[email protected]>
Co-authored-by: Billyyyyy3320 <[email protected]>
Co-authored-by: Billyyyyy3320 <[email protected]>
Co-authored-by: Billyyyyy3320 <[email protected]>
Co-authored-by: Billyyyyy3320 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: