Skip to content

Conversation

@zangjiucheng
Copy link
Member

@zangjiucheng zangjiucheng commented Feb 16, 2025

This pull request introduces changes to the CalendarEvent class to include a new is_cancelled property and updates the related event reminder functionality and unit tests accordingly.

Enhancements to CalendarEvent class:

  • Added a new is_cancelled boolean property to the CalendarEvent class to track the cancelled status of an event. (src/classes/CalendarEvent.ts) [1] [2] [3]
  • Updated the CalendarEvent constructor and the fromGoogleCalendarEvent method to handle the is_cancelled property. (src/classes/CalendarEvent.ts) [1] [2]

Updates to event reminders:

  • Modified the generateEventReminderChannelText function to check the is_cancelled property and adjust the reminder message accordingly. (src/utils/eventReminders.ts) [1] [2]

Unit tests:

  • Added new test cases to verify the correct parsing and handling of cancelled events in the CalendarEvent class and related functions. (tests/unit/classes/CalendarEvent.test.ts, tests/unit/utils/googleCalendar.test.ts) [1] [2] [3] [4]## Description

This change is Reviewable

@zangjiucheng zangjiucheng requested a review from a team as a code owner February 16, 2025 18:27
@zangjiucheng zangjiucheng changed the base branch from main to development February 16, 2025 18:27
@zangjiucheng zangjiucheng merged commit 5d82c50 into development Feb 16, 2025
1 check passed
@zangjiucheng zangjiucheng deleted the j7zang/enhance-message branch February 16, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants