@font-face cause css-loader crash in 5.1.0 #1267
Description
- Operating System: Mac 11.2.2
- Node Version:14.2.0
- NPM Version: 6.14.9
- webpack Version: 5.24.2
- css-loader Version: 5.1.0
Expected Behavior
Don't crash
Actual Behavior
style.less:13 Uncaught Error: Module build failed (from ./node_modules/css-loader/dist/cjs.js):
TypeError: Cannot read property 'raw' of null
Code
The following rules will cause css-loader crash
@font-face {
font-family: "anticon";
src: url(https://github.com/%3Cspan%20class=%22pl-s%22%3E%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E//at.alicdn.com/t/font_1434092639_4910953.eot?#iefix%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E%3C/span%3E) format("embedded-opentype"),
/* this comment is required */
url(https://github.com/%3Cspan%20class=%22pl-s%22%3E%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E//at.alicdn.com/t/font_1434092639_4910953.woff%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E%3C/span%3E) format("woff");
}The following rules will NOT cause css-loader crash
@font-face {
font-family: "anticon";
src: url(https://github.com/%3Cspan%20class=%22pl-s%22%3E%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E//at.alicdn.com/t/font_1434092639_4910953.eot?#iefix%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E%3C/span%3E) format("embedded-opentype"),
// this comment is required
url(https://github.com/%3Cspan%20class=%22pl-s%22%3E%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E//at.alicdn.com/t/font_1434092639_4910953.woff%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E%3C/span%3E) format("woff");
}OR
@font-face {
font-family: "anticon";
src: url(https://github.com/%3Cspan%20class=%22pl-s%22%3E%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E//at.alicdn.com/t/font_1434092639_4910953.eot?#iefix%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E%3C/span%3E) format("embedded-opentype"),
url(https://github.com/%3Cspan%20class=%22pl-s%22%3E%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E//at.alicdn.com/t/font_1434092639_4910953.woff%3Cspan%20class=%22pl-pds%22%3E%22%3C/span%3E%3C/span%3E) format("woff");
}How Do We Reproduce?
Create a font-face rule, use /**/ comment between to url in src attribute
This will make node.raws.value to be null at https://github.com/webpack-contrib/css-loader/pull/1264/files#diff-4a96d95d621a313e78a0a620a8763aaf8f975c2fcdf6feddd6d2db94314673e4R71
so, node.raws.value.raw will cause TypeError: Cannot read property 'raw' of null
It should be node.raws.value!= null,not only typeof node.raws.value === "undefined"
@alexander-akait @cap-Bernardito