Skip to content

Conversation

harish-sethuraman
Copy link
Contributor

@harish-sethuraman harish-sethuraman commented Jan 27, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Added types and standardized readme

Preview here: https://github.com/webpack-contrib/less-loader/blob/e8279bce8e75f1b3785c2b71aad8f513f37896d3/README.md

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #454 (6e27136) into master (059e896) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files           4        4           
  Lines         150      150           
  Branches       33       33           
=======================================
  Hits          141      141           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059e896...6e27136. Read the comment docs.

Type:

```ts
type lessOptions = import('less').options | ((loaderContext: LoaderContext) => import('less').options})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the same in sass-loader

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

@alexander-akait alexander-akait merged commit 10ddc88 into webpack:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants