-
Notifications
You must be signed in to change notification settings - Fork 25
Description
Looking through #422, I noticed that this PR assumes that a brand will a.) follow the GOV.UK Design System’s class naming convention and b.) provide the same utility classes. Sadly, for the case of NHS.UK Frontend (which what we really mean by brand right now), that’s not always true.
Fortunately, the only place this is a problem is for the #{brand}-!-display-none-print class, which is used on a few components where hide_in_print is set to true.
There is currently no equivalent utility class in NHS.UK Frontend, and even if there were, that project uses -u- for utility classes, just to be different.
Given this hide_in_print option, I was wondering if it makes sense to provide the necessary styles in this library. But, this library doesn’t provide component styles.
In which case, authors would need to provide their own CSS:
@include mq($media-type: print) {
.nhsuk-\!-display-none-print {
display: none !important;
}
}Is it worth adding a note in the documentation? I note the brand option isn’t included anyway, so maybe this is all a hidden feature and I should keep quiet 😆