Upgrade to ViewComponent 3.3.0 #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jun 29, 2023
A recent change to ViewComponent[0] makes it call Rails.application.routes.url_helpers which, until now, didn't exist. We can initialize a fake Rails application so it's at least present, despite being totally empty, which will allow the guide build to function. We're very much in the minority in terms of how we're building this guide Rails-free, so it's on us to make it work. [0] ViewComponent/view_component#1765
peteryates
force-pushed
the
view_component-3.3.0
branch
from
3eed7ee to
1e3898e
Compare
frankieroberto
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recent PR means that we need Rails to be set up in order to build the guide.