util/xdp_sample: remove <sys/sysinfo.h> for musl compatibility #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the musl libc environment, `<sys/sysinfo.h>` also defines
the `sysinfo` struct, causing a redefinition conflict:
toolchain-x86_64_gcc-14.2.0_musl/include/linux/kernel.h:5,
from ../../headers/linux/hashtable.h:15,
from xdp_sample.c:33:
toolchain-x86_64_gcc-14.2.0_musl/include/linux/sysinfo.h:8:8: error: redefinition of 'struct sysinfo'
8 | struct sysinfo {
| ^~~~~~~
In file included from xdp_sample.c:24:
toolchain-x86_64_gcc-14.2.0_musl/include/sys/sysinfo.h:10:8: note: originally defined here
10 | struct sysinfo {
| ^~~~~~~
This commit removes the `<sys/sysinfo.h>` include. It seems that
none of its symbols are used in the xdp_sample code anyway.
Signed-off-by: Til Kaiser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the musl libc environment,
<sys/sysinfo.h>also defines thesysinfostruct, causing a redefinition conflict:This commit removes the
<sys/sysinfo.h>include.It seems that none of its symbols are used in the
xdp_samplecode anyway.