Skip to content

[docm] Fix instance code #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2023
Merged

[docm] Fix instance code #119

merged 2 commits into from
Jun 16, 2023

Conversation

webvs2
Copy link

@webvs2 webvs2 commented Jun 15, 2023

Closes #

Description

@jonirrings
Copy link
Collaborator

I will check it later, thx

@webvs2
Copy link
Author

webvs2 commented Jun 16, 2023

There was an error when I ran the example yesterday, and the method of entry has changed after understanding it

@jonirrings
Copy link
Collaborator

great, but {schema:schema} may be shorten as {schema}

jonirrings
jonirrings requested changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@jonirrings jonirrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few to fix

jonirrings
jonirrings approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@jonirrings jonirrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your contribution.

@jonirrings jonirrings merged commit 34cfd94 into xitu:zh-Hans Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonirrings jonirrings jonirrings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webvs2 @jonirrings