Skip to content

Fix visitor problems in api-language #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2017
Merged

Fix visitor problems in api-language #78

merged 1 commit into from
Aug 10, 2017

Conversation

0x0042
Copy link

@0x0042 0x0042 commented Aug 10, 2017

ydfzgyj
ydfzgyj reviewed Aug 10, 2017
View reviewed changes
site/graphql-js/APIReference-Language.md Outdated
@@ -210,9 +210,9 @@ var editedAST = visit(ast, {
});
```

访问方法可以通过提供和节点类型同名的函数来替代 `enter()` 和 `leave()` 函数，或者通过名称的关键字来使用 `enter` 或 `leave` 访问方法，这就造成访问方法的 API 有四种形式：
visitor 可以通过提供和节点类型同名的函数来替代 `enter()` 和 `leave()` 函数，或者通过名称的关键字来使用 visitor 中的 `enter` 或 `leave`，这就造成 visitor 的 API 有四种形式：
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不翻译的英文词在句首时，是否有必要首字母大写？

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有道理

@jonirrings jonirrings merged commit 5a6b699 into xitu:zh-Hans Aug 10, 2017
@0x0042 0x0042 deleted the fix-api-language branch August 11, 2017 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydfzgyj ydfzgyj ydfzgyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x0042 @ydfzgyj @jonirrings