Skip to content

Conversation

ziaratban
Copy link
Contributor

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? no

default db connection not send from $modelClass in one() and all() methods.
so i create a finalConObj() protected method and use in across ActiveQuery class.

also this bug is exists in yii framework.
yiisoft/yii2#18184

default db connection not send from $modelClass in one() and all() methods.
so i create a finalConObj() protected method and use in across ActiveQuery class.

yiisoft/yii2#18184
@samdark samdark added the pr:missing usecase It is not clear what is the use case for the pull request. label Jul 17, 2020
@bizley bizley added pr:request for unit tests Unit tests are needed. severity:BC breaking Breaks backwards compatibility type:bug Bug and removed pr:missing usecase It is not clear what is the use case for the pull request. labels Sep 16, 2020
@yiisoft yiisoft deleted a comment from yii-bot Sep 16, 2020
@bizley bizley self-assigned this Sep 16, 2020
@bizley
Copy link
Member

bizley commented Sep 16, 2020

As already stated in yiisoft/yii2#18184 everything works as intended.

@bizley bizley removed pr:request for unit tests Unit tests are needed. severity:BC breaking Breaks backwards compatibility type:bug Bug labels Sep 16, 2020
@yiisoft yiisoft deleted a comment from yii-bot Sep 16, 2020
@bizley bizley closed this Sep 16, 2020
@ziaratban ziaratban deleted the active-query-db-problem branch September 16, 2020 13:36
@ziaratban ziaratban restored the active-query-db-problem branch September 16, 2020 13:39
@ziaratban ziaratban deleted the active-query-db-problem branch September 16, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants