Skip to content

Case-insensitive HTTP header parsing #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

mchristopher
Copy link
Contributor

This PR updates the HTTP parsing class to ensure that all HTTP header keys are lowercased before returning the result to the caller. This is in-line with RFC2616 and will be compatible with http/2.

@corasaurus-hex
Copy link
Contributor

MICHAEL!!

@corasaurus-hex
Copy link
Contributor

So, I can merge this but there are no tests and I don't know how to cut a release. You wrote all this I'll trust that it works. As far as cutting a release goes...

@mchristopher
Copy link
Contributor Author

Honestly it's been way too long since I setup a release - I believe you need to bump the version in the Zencoder.php file, create a new tag, and wait for Packagist to pick it up.

@corasaurus-hex
Copy link
Contributor

Justin tried it, we'll see how it goes...

ihavenoideawhatiamdoing.jpg

@glensc
Copy link

glensc commented Sep 5, 2019

well. you can typically just git log -p and see commits made in previous release :)

@glensc
Copy link

glensc commented Sep 5, 2019

oh, and thanks for handling this, that promptly, I don't need to use dev-xxx in my composer.json :)

@glensc
Copy link

glensc commented Sep 5, 2019

and close this one: #24

@mchristopher
Copy link
Contributor Author

@nate @jgreer I think you guys need to reach out to Packagist and take ownership of the Zencoder package https://packagist.org/packages/zencoder/zencoder-php

I'd recommend setting up web hooks on this repo once you have ownership so updates are automatic in the future...

@glensc
Copy link

glensc commented Sep 6, 2019

I think for that need to submit issue to here:

i've seen similar transfer requests:

so I think it's best if you can reach out @tblanchard, I'm not sure if that's the same packagist user: https://packagist.org/users/tblanchard/

@glensc
Copy link

glensc commented Sep 10, 2019

@ALL: please post here when the new version 2.2.4 is published in packagist:

is anyone from @zencoder dealing with that? please share information!

@jgreer
Copy link
Contributor

jgreer commented Sep 10, 2019

We've reached out regarding this, but may end up needing to wait for Packagist to automatically pick up the new version. I do not know how often it checks.

@glensc
Copy link

glensc commented Sep 10, 2019

reached out to whom? to my knowledge, packagist.org reacts on pushes, you need github webhook to be set up to send payload to packagist. there's also manual "update" button you can force it to pull if you really own (or have rights) for the package:

image

@glensc
Copy link

glensc commented Sep 16, 2019

2.2.4 appeared now in packagist:

I wished someone sent ping here about success :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants