drivers: sensor: lsm6dso: add support for tilt and tap triggers #89205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
ivanwagner
force-pushed
the
lsm6dso-add-tilt-and-tap
branch
2 times, most recently
from
b47a10a to
0c23de8
Compare
Tilt or Tap can be selected via config and further tap parameters can be configured via DT. Signed-off-by: Ivan Wagner <[email protected]>
ivanwagner
force-pushed
the
lsm6dso-add-tilt-and-tap
branch
from
0c23de8 to
c0a6b5a
Compare
|
Anyone willing to take a look a this? |
MaureenHelm
previously approved these changes
May 21, 2025
kartben
previously requested changes
May 23, 2025
avisconti
reviewed
May 26, 2025
|
@ivanwagner can you take a look at the recent comments? Thanks! |
I will make changes and test it next week and push everything so you can have a look. Thank you |
Improvements include: check error codes, log level adjustments, removed unreachable code, disable tilt when not used, call optimized interrupt handler when tilt and tap are not used. Signed-off-by: Ivan Wagner <[email protected]>
yperess
previously approved these changes
Jun 3, 2025
| @@ -206,10 +516,11 @@ static void lsm6dso_handle_interrupt(const struct device *dev) | |||
| #endif | |||
| } | |||
|
|
|||
| gpio_pin_interrupt_configure_dt(&cfg->gpio_drdy, | |||
| GPIO_INT_EDGE_TO_ACTIVE); | |||
| gpio_pin_interrupt_configure_dt(&cfg->gpio_drdy, GPIO_INT_EDGE_TO_ACTIVE); | |||
There was a problem hiding this comment.
Generally you don't want to turn on/off the edge triggers. This is outside of the scope of this PR, but I recommend revisiting this for this driver. On level interrupts you want to turn it off because it'll keep firing until you read the status register. With edge interrupts it's safe to leave it on this way you're not missing events.
avisconti
requested changes
Jun 4, 2025
Added comments ad the end of preprocessor if else endif blocks Signed-off-by: Ivan Wagner <[email protected]>
ivanwagner
force-pushed
the
lsm6dso-add-tilt-and-tap
branch
from
3c24ae5 to
4770837
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
yperess
approved these changes
Jun 4, 2025
avisconti
approved these changes
Jun 5, 2025
MaureenHelm
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for tilt, tap and double tap triggers. As an example ST IIS2DLPC sensor was taken as an example. In fact DT new properties are taken from there with the same philosophy.
A new sensor trigger value has been added: SENSOR_TRIG_TILT
When the interrupt handler is called, access to 5 registers will determine information regarding any interrupt flag available on this devices. This adds extensibility for future features at a cost of accessing 5 registers.