drivers: flash: nrf_mram: wait until mramc is ready before write #97691
+50
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
reviewed
Oct 16, 2025
| LOG_DBG("write: %p:%zu", (void *)addr, len); | ||
|
|
||
| memcpy((void *)addr, data, len); | ||
| for (uint32_t i = 0; i < (len / MRAM_WORD_SIZE); i++) { |
There was a problem hiding this comment.
static inline to avoid duplication
kl-cruz
reviewed
Oct 16, 2025
drivers/flash/soc_flash_nrf_mram.c
Outdated
| #define ERASE_VALUE 0xff | ||
|
|
||
| #define SOC_NRF_MRAMC_ADDR DT_REG_ADDR(DT_PARENT(DT_DRV_INST(0))) | ||
| #define SOC_NRF_MRAMC_READY_REG (MRAM_START + 0x400) |
There was a problem hiding this comment.
Already part of nrfx: https://github.com/NordicSemiconductor/nrfx/blob/master/hal/nrf_mramc.h#L349
rghaddab
force-pushed
the
rghaddab/mram-wait-ready
branch
2 times, most recently
from
cbb9e28 to
c88ab19
Compare
When writes are issued to the mram controller without verifying that it is ready, it can cause the reads to be stalled until all writes finish. Fix this by adding a wait busy loop after each MRAM_WORD aligned write. Signed-off-by: Riadh Ghaddab <[email protected]>
rghaddab
force-pushed
the
rghaddab/mram-wait-ready
branch
from
c88ab19 to
562b993
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writes are issued to the mram controller without verifying that it is ready, it can cause the reads to be stalled until all writes finish. Fix this by adding a wait busy loop before any MRAM_WORD aligned write.