This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Aro sync #204
Merged
Aro sync #204
+176
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehaas
reviewed
Oct 24, 2025
src/Translator.zig
Outdated
| // return @ptrCast(&self.*.<field_name>); | ||
| const address_of = try ZigTag.address_of.create(t.arena, field_access); | ||
| const casted = try ZigTag.ptr_cast.create(t.arena, address_of); | ||
| const alinged = try ZigTag.align_cast.create(t.arena, address_of); |
Collaborator
There was a problem hiding this comment.
typo in the variable name here (alinged)
Member
Author
|
|
This was referenced Oct 31, 2025
This was referenced Nov 2, 2025
Member
|
Unblocked now? |
Member
Author
|
I still need to finish Vexu/arocc#918. |
Member
|
Nice, looks like a good time to sync ziglang/zig too then? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201
Closes #191
Closes #184
Closes #188
Closes #186
Closes #189
Closes #213
Closes #216
Closes #219
Closes #218
Closes #224