[PHOENIX-7095] Implement Statement.closeOnCompletion() and fix related close() bugs - ASF JIRA

XML

Word

Printable

JSON

Release Note:

Hide
Phoenix now implements the Statement.closeOnCompletion() method.
Phoenix now calls Statement.closeOnCompletion() when generating DatabaseMetaData resultSets.
Phoenix now correctly calls close() on all Statements when a Connection is closed().
Phoenix now closes the open ResultSet on a Statement when another statement is executed on the Statement object.

Note that Phoenix previously did not comply with the JDBC specification, and allowed for multiple open ResultSets on the same Statement object.
Application code that dependeded on this bug may need to be rewritten.

Show
Phoenix now implements the Statement.closeOnCompletion() method. Phoenix now calls Statement.closeOnCompletion() when generating DatabaseMetaData resultSets. Phoenix now correctly calls close() on all Statements when a Connection is closed(). Phoenix now closes the open ResultSet on a Statement when another statement is executed on the Statement object. Note that Phoenix previously did not comply with the JDBC specification, and allowed for multiple open ResultSets on the same Statement object. Application code that dependeded on this bug may need to be rewritten.

Umbrella ticket, so that the three dependent tickets can be fixed in a single commit.

fixes

PHOENIX-7092 PhoenixDatabaseMetadata leaves unclosed Statements around

PHOENIX-7093 PhoenixConnection doesn't close its Statements on close()

PHOENIX-7088 PhoenixStatement leaks ResultSets

is a parent of

PHOENIX-7092 PhoenixDatabaseMetadata leaves unclosed Statements around

PHOENIX-7093 PhoenixConnection doesn't close its Statements on close()

PHOENIX-7088 PhoenixStatement leaks ResultSets

is related to

PHOENIX-7316 Need close more Statements

relates to

PHOENIX-7149 Use Statement#closeOnCompletion for PhoenixDataBaseMetaData queries

links to

GitHub Pull Request #1729

(1 is a parent of, 1 is related to, 1 relates to, 1 links to)