Skip to content

ERB: Better embedding of Ruby #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RunDevelopment merged 1 commit into from
Nov 22, 2021
Merged

ERB: Better embedding of Ruby #3192

RunDevelopment merged 1 commit into from
Nov 22, 2021

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Nov 10, 2021

This removes the Prism.languages.extend to decouple ERB and Ruby. Ruby is now free to change withing ERB having to worry.

@github-actions
Copy link

github-actions bot commented Nov 10, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +20 B (+7.5%).

Details
file master pull size diff % diff
components/prism-erb.min.js 265 B 285 B +20 B +7.5%

Generated by 🚫 dangerJS against 1e88986

@RunDevelopment RunDevelopment merged commit 336edee into PrismJS:master Nov 22, 2021
@RunDevelopment RunDevelopment deleted the erb-impr branch November 22, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement language-definitions needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RunDevelopment