[material][Rating] Fix keyboard navigation behavior in Safari #47461
+571
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-47461--material-ui.netlify.app/ Bundle size report
|
vmaineng
approved these changes
Dec 12, 2025
vmaineng
left a comment
vmaineng
left a comment
There was a problem hiding this comment.
This update creates a predictable keyboard flow. The normalization of Safari’s legacy keys and the single handler guard remove the double-step issue nicely. The roving tabIndex logic is also spot-on and aligns well with WAI-ARIA radio patterns. Great job on this!
ZeeshanTamboli
added
the
browser: Safari
mj12albert
reviewed
Dec 16, 2025
| @@ -0,0 +1,422 @@ | |||
| import 'docs/src/modules/components/bootstrap'; | |||
| @@ -0,0 +1 @@ | |||
| {} | |||
| await renderFixture('Rating/BasicRating'); | ||
|
|
||
| const activeEl = page.locator(':focus'); | ||
| const checked = () => page.locator('input[name="rating-test"]:checked'); |
Member
There was a problem hiding this comment.
Why does this test need to change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the keyboard accessibility and navigation behavior of the Rating component. It primarily focuses on inconsistent/incorrect behavior in Safari. This is because the Safari browser handles focus, radio navigation, and keyboard events differently from other browsers. As a result, keyboard users experienced (BUG):
This PR makes the Rating component fully keyboard-accessible and consistent across all major browsers.
Fix implemented
This PR introduces several improvements that together standardize keyboard behavior:
Cross-browser key handling
"Left","Right","Up","Down"event keys.nextValueForKeyhelper.Reliable, predictable focus behavior (roving
tabIndex)value == null, the “empty” radio hastabIndex=0.tabIndex=0.tabIndex=-1.Single-step arrow key navigation
event.defaultPreventedinsidehandleKeyDownso that:Consistent behavior across states
Tests
pnpm test:unit -- Ratingpasses locally.Related issue
Fixes #34202