Skip to content

[appbar] Fix inherit color CSS variable not getting applied #47518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZeeshanTamboli wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[appbar] Fix inherit color CSS variable not getting applied #47518

ZeeshanTamboli wants to merge 3 commits into from
+1 −0

Conversation

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Dec 23, 2025 •
edited
Loading

The --AppBar-color was defined but not used when color="inherit". Use it when color="inherit", where it will inherit the color of the Paper component.

It was not used because below it is explicitly skipping inherit, so color was not applied:

props.enableColorOnDark === true && !['inherit', 'transparent'].includes(props.color)
props.enableColorOnDark === false && !['inherit', 'transparent'].includes(props.color)

@ZeeshanTamboli ZeeshanTamboli added the scope: app bar Changes related to the app bar. label Dec 23, 2025
@mui-bot
Copy link

mui-bot commented Dec 23, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-47518--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 🔺+28B(+0.01%) ▼-1B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 576647b

@ZeeshanTamboli ZeeshanTamboli changed the title [appbar] Fix inherit color [appbar] Fix inherit color CSS variable not getting applied Dec 23, 2025
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review December 23, 2025 13:11
@ZeeshanTamboli ZeeshanTamboli added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sai6855 sai6855 Awaiting requested review from sai6855

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

scope: app bar Changes related to the app bar. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeeshanTamboli @mui-bot