-
Notifications
You must be signed in to change notification settings - Fork 1k
Migrate the edit location page from leaflet to Maplibre #6675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the edit location page from leaflet to Maplibre #6675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR successfully migrates the edit location page from Leaflet to MapLibre GL JS, modernizing the mapping library while maintaining functionality. The migration includes coordinate system adjustments, API method updates, and improvements to the zoom behavior with exponential easing.
Key changes:
- Replaced Leaflet-specific map controls with MapLibre equivalents (NavigationControl, GeolocateControl)
- Updated coordinate handling from Leaflet's lat/lng order to MapLibre's lng/lat order throughout
- Disabled rotation features (roll, drag rotate, pitch) for better location selection UX
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commit migrates the user home location page (the "Edit" tab on the user profile) from Leaflet to MapLibre GL JS. This is part of a wider migration to MapLibre across the website. The change follows the pattern established in the dashboard migration.
4f649fd to
7a8134e
Compare
0d419b3 to
3aa7d53
Compare
…le between the secondary maps
3aa7d53 to
a801f7f
Compare
|
For crying out loud I thought I had turned off copilot access to this repository! If anybody can navigate the github documentation better than me to find a way of getting rid of it please let me know... |
Description
This PR migrates the edit location page from leaflet to maplibre.
This has two intentional changes:
I can change this to the previous behaviour, but that did not seem entirely intentional.
I disabled rotation, pich and yaw for this one, since for selecting a location you likely want this.
How has this been tested?
Via docker, manually starting the map, interactig with it.
Locations get set appropriately, all buttons work.