Skip to content

Conversation

@CommanderStorm
Copy link
Contributor

@CommanderStorm CommanderStorm commented Jan 4, 2026

Description

This PR migrates the edit location page from leaflet to maplibre.

This has two intentional changes:

  • When clicking on the "Show" button, we now "fly" there instead of "fast-zoom-jump" (does not look very polished).
    I can change this to the previous behaviour, but that did not seem entirely intentional.
  • the zoom buttons have rounded corners like on the main map

I disabled rotation, pich and yaw for this one, since for selecting a location you likely want this.

How has this been tested?

Via docker, manually starting the map, interactig with it.
Locations get set appropriately, all buttons work.

Copilot AI review requested due to automatic review settings January 4, 2026 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR successfully migrates the edit location page from Leaflet to MapLibre GL JS, modernizing the mapping library while maintaining functionality. The migration includes coordinate system adjustments, API method updates, and improvements to the zoom behavior with exponential easing.

Key changes:

  • Replaced Leaflet-specific map controls with MapLibre equivalents (NavigationControl, GeolocateControl)
  • Updated coordinate handling from Leaflet's lat/lng order to MapLibre's lng/lat order throughout
  • Disabled rotation features (roll, drag rotate, pitch) for better location selection UX

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This commit migrates the user home location page (the "Edit" tab on the user profile) from Leaflet to MapLibre GL JS. This is part of a wider migration to
MapLibre across the website. The change follows the pattern established in the dashboard migration.
@CommanderStorm CommanderStorm force-pushed the migrate-user-location-edit branch from 4f649fd to 7a8134e Compare January 4, 2026 19:46
@CommanderStorm CommanderStorm force-pushed the migrate-user-location-edit branch from 0d419b3 to 3aa7d53 Compare January 5, 2026 09:32
@CommanderStorm CommanderStorm force-pushed the migrate-user-location-edit branch from 3aa7d53 to a801f7f Compare January 5, 2026 17:33
@CommanderStorm CommanderStorm requested a review from hlfan January 5, 2026 17:33
@tomhughes
Copy link
Member

For crying out loud I thought I had turned off copilot access to this repository!

If anybody can navigate the github documentation better than me to find a way of getting rid of it please let me know...

@hlfan hlfan merged commit f935017 into openstreetmap:master Jan 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants