Skip to content

Conversation

@pcorpet
Copy link

@pcorpet pcorpet commented Nov 11, 2025

This change is compatible with previous code, it makes it more obvious that the library does not modify the array of plugins and only iterates over the array.

Fixes #266

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date (I don't think they need a change)
  • I included tests (or that’s not needed)

Description of changes

Change the type of the first parameter of use to accept not only arrays but also readonly arrays (immutable). As the library does not modify it, we can accept this wider type.

This change is compatible with previous code, it makes it more obvious that the library does not modify
the array of plugins and only iterates over the array.

Fixes unifiedjs#266
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Nov 11, 2025
@github-actions

This comment has been minimized.

@pcorpet pcorpet mentioned this pull request Nov 11, 2025
4 tasks
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b69689b) to head (fcba4db).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines         1364      1380   +16     
=========================================
+ Hits          1364      1380   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 11, 2025
@wooorm
Copy link
Member

wooorm commented Nov 18, 2025

closing, see #266 (comment)

@wooorm wooorm closed this Nov 18, 2025
@github-actions

This comment has been minimized.

@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Nov 18, 2025
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Development

Successfully merging this pull request may close these issues.

Readonly Array for PluggableList

2 participants