Skip to content

Deprecate default of Git.show(strip_newline_in_stdout=False) #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Deprecate default of Git.show(strip_newline_in_stdout=False) #1948

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a943fa3
deprecation warning for Git.show() w/o string_newline=False
SonOfLilit Jul 30, 2024
10fb861
fix tests that assumed default initial branch setting
SonOfLilit Jul 30, 2024
5254159
run pre-commit
SonOfLilit Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
run pre-commit
  • Loading branch information
@SonOfLilit
SonOfLilit committed Jul 30, 2024
commit 52541595ed0cc0d8676ab4875b2cb1f448de1247
3 changes: 2 additions & 1 deletion git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,8 @@ def execute(
warnings.warn(
"Git.show() has strip_newline_in_stdout=True by default, which probably isn't what you want and will "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Git.show() has strip_newline_in_stdout=True by default, which probably isn't what you want and will "
"Git.show() has strip_newline_in_stdout=True by default, which probably isn't what you want and may "

"change in a future version. It is recommended to use Git.show(..., strip_newline_in_stdout=False)",
DeprecationWarning
DeprecationWarning,
stacklevel=1,
)

# Allow the user to have the command executed in their working dir.
Expand Down
Loading