Skip to content

Add URI to message of TimeoutException when timeout #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Atry
Copy link

@Atry Atry commented Nov 9, 2015

No description provided.

@slandelle
Copy link
Contributor

Hey @Atry !
Sorry for the delay :(

I have 2 issues with your PR (appart from fact that your branch has conflicts and can't be merged).

First, I display those Exception messages in Gatling, and having the full url in the message would be both super long and would blow off the number of different messages that get displayed. I would be fine with either having a config option to switch between current behaviour and the one you suggest.

Then, it's a bad idea to store the full Request inside the Task. Cancelled tasks could be lingering some time in the Timer, increasing memory pressure (e.g. the request body won't be quickly gc'ed). Only storing the Uri should suffice.

@Atry
Copy link
Author

Atry commented Dec 17, 2015

This PR is a duplicate of #1031 , for different branch.

@slandelle
Copy link
Contributor

Oh right, sorry.
So actually, I think you're right, and providing the url might prove useful, even if not sufficient for every use case (think ElasticSearch that always send a JSON body, even for GET requests).

If you agree with my suggestions, please feel free to provide a PR.

@Atry
Copy link
Author

Atry commented Dec 17, 2015

I was convinced by your design mentioned in #1031 that the users could store URL in their error handler.

@slandelle
Copy link
Contributor

OK, then :)

@slandelle slandelle closed this Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants