-
Notifications
You must be signed in to change notification settings - Fork 152
docs: add Tauri prerequisites and dev/build commands to README #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe README.md file was updated to include comprehensive documentation for desktop application development using Tauri. This includes prerequisites, installation steps for Rust and system dependencies, and instructions for running and building the desktop application. Existing web development instructions remain unchanged, with only additions and minor formatting adjustments made. Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
171-171
: Correct spelling of jQuery.The To Dos list should reference “jQuery” (capital “Q”) rather than “JQuery” for consistency with the library’s official branding.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(3 hunks)
🔇 Additional comments (5)
README.md (5)
13-19
: Prerequisites section is clear and well-structured.The new “Prerequisites” section cleanly separates web and desktop requirements, with appropriate version calls for Node.js and npm. Heading levels and bullet formatting align with the rest of the document.
20-23
: Desktop development prerequisites are correctly listed.Rust and system dependencies are properly highlighted under a clear subheading.
24-38
: Rust installation instructions are accurate.Step-by-step guidance (rustup.rs link, environment sourcing, version checks) is comprehensive and easy to follow.
40-91
: Platform-specific dependency instructions are comprehensive.Windows, macOS, and major Linux distributions are all covered with explicit package lists. Formatting and code blocks are consistent.
113-129
: Tauri development and build commands are correct.“npm run tauri dev” and “npm run tauri build” are the standard commands, and the output path is clearly specified.
@niladrix719 pls review the pr , thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets move the whole getting started to a new md file as its in the circuitverse main repo.
@Arnabdaz alright would make the changes, thanks for your review |
Fixes #509
Describe the changes you have made in this PR -
Added Tauri prerequisites, Rust installation steps, and npm run tauri dev/build commands to README.
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit