Fix for CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐕 Corgea issued a PR to fix a vulnerability found in insecure-java/src/main/java/com/example/catapp/controllers/CommentController.java.
It is CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') that has a severity of 🔴 High.
🪄 Fix explanation
The fix mitigates the XSS vulnerability by sanitizing user input using "StringEscapeUtils.escapeHtml4", which neutralizes potentially harmful HTML content before storing it in the database.
- The fix imports "StringEscapeUtils" from Apache Commons Text to handle input sanitization.
- The method "escapeHtml4" is applied to "commentText" to escape HTML tags, preventing script execution.
- The sanitized input is then safely stored in the "Comment" object, mitigating XSS risks.
💡 Important Instructions
Ensure that all user inputs across the application are similarly sanitized to prevent XSS vulnerabilities.
See the issue and fix in Corgea.