Skip to content

Fix for CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion insecure-java/src/main/java/com/example/catapp/controllers/CommentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.example.catapp.controllers;

import org.apache.commons.text.StringEscapeUtils;
import com.example.catapp.models.Comment;
import com.example.catapp.repositories.CommentRepository;
import org.springframework.beans.factory.annotation.Autowired;
Expand All @@ -24,7 +25,7 @@ public String addCommentForm() {
@PostMapping("/addComment")
public String addComment(@RequestParam String commentText, Model model) {
Comment comment = new Comment();
comment.setText(commentText); // No sanitization
comment.setText(StringEscapeUtils.escapeHtml4(commentText)); // Sanitize input
commentRepository.save(comment);
model.addAttribute("message", "Comment added");
return "addCommentResult"; // Returns addCommentResult.html
Expand Down