-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[py][BiDi] use constant for LogLevel #15677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
for some reason your branch failed when building the docs.. I can't see anything you changed that would cause that. I just merged trunk into your branch to run CI again. |
User description
🔗 Related Issues
💥 What does this PR do?
Use typed string for LogLevel which matches the rest bindings
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement, Tests
Description
Introduced
LogLevel
constants for BiDi log levelsUpdated tests to use
LogLevel
constantsImproved consistency with other Selenium bindings
Changes walkthrough 📝
log.py
Add LogLevel constants for BiDi logging
py/selenium/webdriver/common/bidi/log.py
LogLevel
class with log level constantsbidi_script_tests.py
Update BiDi log tests to use LogLevel constants
py/test/selenium/webdriver/common/bidi_script_tests.py
LogLevel
constants in assertionsLogLevel
usage in tests