Skip to content

[py][BiDi] use constant for LogLevel #15677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions py/selenium/webdriver/common/bidi/log.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,12 @@ def from_json(cls, json):
stacktrace=json["stackTrace"],
type_=json["type"],
)


class LogLevel:
"""Represents log level."""

DEBUG = "debug"
INFO = "info"
WARN = "warn"
ERROR = "error"
7 changes: 4 additions & 3 deletions py/test/selenium/webdriver/common/bidi_script_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.

from selenium.webdriver.common.bidi.log import LogLevel
from selenium.webdriver.common.by import By
from selenium.webdriver.support.ui import WebDriverWait

Expand All @@ -31,7 +32,7 @@ def test_logs_console_messages(driver, pages):
WebDriverWait(driver, 5).until(lambda _: log_entries)

log_entry = log_entries[0]
assert log_entry.level == "info"
assert log_entry.level == LogLevel.INFO
assert log_entry.method == "log"
assert log_entry.text == "Hello, world!"
assert log_entry.type_ == "console"
Expand All @@ -55,7 +56,7 @@ def log_error(entry):
assert len(log_entries) == 1

log_entry = log_entries[0]
assert log_entry.level == "error"
assert log_entry.level == LogLevel.ERROR
assert log_entry.method == "error"
assert log_entry.text == "I am console error"
assert log_entry.type_ == "console"
Expand Down Expand Up @@ -105,7 +106,7 @@ def test_javascript_error_messages(driver, pages):

log_entry = log_entries[0]
assert log_entry.text == "Error: Not working"
assert log_entry.level == "error"
assert log_entry.level == LogLevel.ERROR
assert log_entry.type_ == "javascript"


Expand Down
Loading