Skip to content

Fixes: #12108: Add Ridge regression implementation to machine_learning #12251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ridge regression
  • Loading branch information
ankana2113 committed Oct 23, 2024
commit 7484cda51603ca8ec16f6319a3fef3308419a802
14 changes: 0 additions & 14 deletions machine_learning/ridge_regression/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,8 @@ def __init__(self, alpha:float=0.001, regularization_param:float=0.1, num_iterat
self.num_iterations:int = num_iterations
self.theta:np.ndarray = None

<<<<<<< HEAD

def feature_scaling(self, X:np.ndarray) -> tuple[np.ndarray, np.ndarray, np.ndarray]:
=======
def feature_scaling(self, X):
>>>>>>> d4fc2bf852ec4a023380f4ef367edefa88fd6881
mean = np.mean(X, axis=0)
std = np.std(X, axis=0)

Expand Down Expand Up @@ -43,13 +39,8 @@ def predict(self, X:np.ndarray) -> np.ndarray:
X_scaled, _, _ = self.feature_scaling(X)
return X_scaled.dot(self.theta)

<<<<<<< HEAD
def compute_cost(self, X:np.ndarray, y:np.ndarray) -> float:
X_scaled, _, _ = self.feature_scaling(X)
=======
def compute_cost(self, X, y):
X_scaled, _, _ = self.feature_scaling(X)
>>>>>>> d4fc2bf852ec4a023380f4ef367edefa88fd6881
m = len(y)

predictions = X_scaled.dot(self.theta)
Expand All @@ -69,13 +60,8 @@ def mean_absolute_error(self, y_true:np.ndarray, y_pred:np.ndarray) -> float:
y = df["ADR"].values
y = (y - np.mean(y)) / np.std(y)

<<<<<<< HEAD
# added bias term to the feature matrix
X = np.c_[np.ones(X.shape[0]), X]
=======
# Add bias term (intercept) to the feature matrix
X = np.c_[np.ones(X.shape[0]), X]
>>>>>>> d4fc2bf852ec4a023380f4ef367edefa88fd6881

# initialize and train the ridge regression model
model = RidgeRegression(alpha=0.01, regularization_param=0.1, num_iterations=1000)
Expand Down