Skip to content

Fixes issue #12233: Avoid log(0) in KL, ruff and build checks #12263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1cb79bc
added ridge regression
ankana2113 Oct 23, 2024
b72320b
added ridge regression
ankana2113 Oct 23, 2024
d4fc2bf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2024
a84d209
added ridge regression
ankana2113 Oct 23, 2024
6fc134d
added ridge regression
ankana2113 Oct 23, 2024
21fe32f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2024
7484cda
ridge regression
ankana2113 Oct 23, 2024
b1353dd
ridge regression
ankana2113 Oct 23, 2024
2eeb450
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2024
1713cbe
resolved errors
ankana2113 Oct 23, 2024
3876437
resolved conflicts
ankana2113 Oct 23, 2024
c76784e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2024
544a38b
resolved conflicts
ankana2113 Oct 23, 2024
d5963b2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2024
b0255a8
added doctests
ankana2113 Oct 24, 2024
d8c0b7c
Merge branch 'main' of https://github.com/ankana2113/Python
ankana2113 Oct 24, 2024
59d3ceb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 24, 2024
83d7252
ruff and minor checks
ankana2113 Oct 24, 2024
1918aac
Merge branch 'main' of https://github.com/ankana2113/Python
ankana2113 Oct 24, 2024
f614b2e
minor chenges
ankana2113 Oct 24, 2024
254b9bf
minor checks
ankana2113 Oct 24, 2024
97eb853
minor checks
ankana2113 Oct 24, 2024
dcf47d4
minor changes
ankana2113 Oct 24, 2024
0ea341a
descriptive names
ankana2113 Oct 24, 2024
1ff7975
Fix ruff check in loss_functions.py
ankana2113 Oct 24, 2024
1459adf
fixed pre-commit issues
ankana2113 Oct 24, 2024
0c04372
Merge pull request #1 from ankana2113/main
ankana2113 Oct 24, 2024
5c2d1fe
added largest rectangle histogram function
ankana2113 Oct 24, 2024
50d5bb1
added largest rectangle histogram function
ankana2113 Oct 24, 2024
d029119
Merge branch 'master' of https://github.com/ankana2113/Python
ankana2113 Oct 24, 2024
b00284f
Merge branch 'largest_rect'
ankana2113 Oct 24, 2024
bfb8167
added kadane's algo
ankana2113 Oct 24, 2024
91f0395
Merge pull request #2 from ankana2113/kadane_algo
ankana2113 Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Oct 23, 2024
commit c76784e7084f514dd7cd44698f57bbb720c7ebdc
18 changes: 9 additions & 9 deletions machine_learning/ridge_regression/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,19 @@


class RidgeRegression:
def __init__(self,
alpha: float = 0.001,
regularization_param: float = 0.1,
num_iterations: int = 1000,
) -> None:
def __init__(
self,
alpha: float = 0.001,
regularization_param: float = 0.1,
num_iterations: int = 1000,
) -> None:
self.alpha: float = alpha
self.regularization_param: float = regularization_param
self.num_iterations: int = num_iterations
self.theta: np.ndarray = None

def feature_scaling(
self, X: np.ndarray

Check failure on line 18 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:18:15: N803 Argument name `X` should be lowercase
) -> tuple[np.ndarray, np.ndarray, np.ndarray]:
mean = np.mean(X, axis=0)
std = np.std(X, axis=0)
Expand All @@ -30,7 +31,7 @@
m, n = x_scaled.shape
self.theta = np.zeros(n) # initializing weights to zeros

for i in range(self.num_iterations):

Check failure on line 34 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (B007)

machine_learning/ridge_regression/model.py:34:13: B007 Loop control variable `i` not used within loop body
predictions = x_scaled.dot(self.theta)
error = predictions - y

Expand All @@ -40,8 +41,8 @@
) / m
self.theta -= self.alpha * gradient # updating weights

def predict(self, X: np.ndarray) -> np.ndarray:

Check failure on line 44 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:44:23: N803 Argument name `X` should be lowercase
X_scaled, _, _ = self.feature_scaling(X)

Check failure on line 45 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:45:9: N806 Variable `X_scaled` in function should be lowercase
return X_scaled.dot(self.theta)

def compute_cost(self, x: np.ndarray, y: np.ndarray) -> float:
Expand All @@ -49,10 +50,9 @@
m = len(y)

predictions = x_scaled.dot(self.theta)
cost = (
1 / (2 * m)) * np.sum((predictions - y) ** 2) + (
self.regularization_param / (2 * m)
) * np.sum(self.theta**2)
cost = (1 / (2 * m)) * np.sum((predictions - y) ** 2) + (
self.regularization_param / (2 * m)
) * np.sum(self.theta**2)
return cost

def mean_absolute_error(self, y_true: np.ndarray, y_pred: np.ndarray) -> float:
Expand All @@ -61,9 +61,9 @@

# Example usage
if __name__ == "__main__":
df = pd.read_csv("ADRvsRating.csv")

Check failure on line 64 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (PD901)

machine_learning/ridge_regression/model.py:64:5: PD901 Avoid using the generic variable name `df` for DataFrames
x = df[["Rating"]].values

Check failure on line 65 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (PD011)

machine_learning/ridge_regression/model.py:65:9: PD011 Use `.to_numpy()` instead of `.values`
y = df["ADR"].values

Check failure on line 66 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (PD011)

machine_learning/ridge_regression/model.py:66:9: PD011 Use `.to_numpy()` instead of `.values`
y = (y - np.mean(y)) / np.std(y)

# added bias term to the feature matrix
Expand Down
Loading