Skip to content

New version with english comments #12762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update time_algo_exec.py
  • Loading branch information
robohie authored May 21, 2025
commit f8f7ed1d65acbce3cc6db7e9803b4fbd49333a47
19 changes: 12 additions & 7 deletions other/time_algo_exec.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@

# This module contains codes about algorithms complexity as to estimate the time
# an algorithm will take to be run.
# Why do we find it usable ? Because, knowing this kind of information tells you if your code
# or solution is efficient or not ; it helps you not to fall trying to run such a code.
# Why do we find it usable ?
# Because, knowing this kind of information tells you if your code or solution is
# efficient or not ; it helps you not to fall trying to run such a code.


def calc(operations: dict) -> float:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What doctest for calc function are you talking about?

"""
calc(operation: dict) -> float:
This function aims to calculate how long an algorithm take, knowing only primary operations
:param operations: A dictionary where the values are tuples, consisting of the number of times
an operation is performed and its execution time, and the key should
preferably be the name of the operation for better clarity and usability.
:return: the time needed for the execution of this algorithm(if format is okey for "operations") or 0
This function aims to calculate how long an algorithm take,
knowing only primary operations
:param operations:
A dictionary where the values are tuples, consisting of the number of times
an operation is performed and its execution time, and the key should,
preferably, be the name of the operation for better clarity and usability.
:return: the time needed for the execution of this algorithm
#>>> operations1 = {"addition":(2, 0.1), "subtraction":(1, 0.2)}
#>>> operations2 = {"addition":(2, 0.1), "subtraction":(1, 0.2, 1)}
#>>> calc(operations1)
Expand All @@ -24,8 +27,10 @@ def calc(operations: dict) -> float:
"""
temps = 0
for couple in operations.values():
# Case you give a shorter or a longer tuple
if len(couple) != 2:
return 0
# Otherwise
temps += couple[0] * couple[1]

return temps
Expand Down