8357621: G1: Clean up G1BiasedArray

[tschatzl]

Hi all,

please review this minor touch-up of the G1BiasedArray classes, removing some unused methods and improving method visibility a bit.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357621: G1: Clean up G1BiasedArray (Enhancement - P4)

Reviewers

• Stefan Johansson (@kstefanj - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25406/head:pull/25406
$ git checkout pull/25406

Update a local copy of the PR:
$ git checkout pull/25406
$ git pull https://git.openjdk.org/jdk.git pull/25406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25406

View PR using the GUI difftool:
$ git pr show -t 25406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25406.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357621: G1: Clean up G1BiasedArray

Reviewed-by: sjohanss, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• a50d3be: 8312198: [macos] metal pipeline - window rendering stops after display sleep
• aac287e: 8353581: Support for import module in JShell's code completion
• 4a4209f: 8357685: Change the type of Integer::digits from char[] to byte[]
• ... and 23 more: https://git.openjdk.org/jdk/compare/ae7ae847d4cb0dc2caf7bdc6a82673287cba8d30...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (03da340c)
• 01: Full - Incremental (fa1c19c8)
• 00: Full (77b6ff36)

[kstefanj]

Looks good.

[kstefanj]

Or are there build issues.

[kstefanj]

Seems to be used by testing.

[kstefanj]

Looks like base() needs to be public for testing as well :(

[tschatzl]

Sorry for all these issues, I just found out that I did not have gtests configured for my build. Should be fixed now.

I moved the test helper methods into the test.

[tschatzl]

The two GHA failures seem to be something unrelated, CDS issues.

Thanks @albertnetymk @kstefanj for your reviews

/integrate

[openjdk]

Going to push as commit 9946c85.
Since your change was applied there have been 30 commits pushed to the master branch:

• 5cdeef8: 8331859: [PPC64] Remove support for Power7 and older
• a37e826: 8357649: IGV: add block index to the supplemental node properties
• 3dbd2d3: 8347570: Configure fails on macOS if directory name do not have correct case
• ... and 27 more: https://git.openjdk.org/jdk/compare/ae7ae847d4cb0dc2caf7bdc6a82673287cba8d30...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 9946c85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.