-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: cmb69/php-sdk-binary-tools
base: master
head repository: php/php-sdk-binary-tools
compare: master
- 17 commits
- 116 files changed
- 4 contributors
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d683a09 - Browse repository at this point
Copy the full SHA d683a09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ae549b - Browse repository at this point
Copy the full SHA 8ae549bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a4ca65 - Browse repository at this point
Copy the full SHA 8a4ca65View commit details
Commits on Aug 18, 2024
-
Fix reading series from cache if fetching fails
`Fetcher::getByUri()` returns a string (and since it is a public method we don't want to change that for now), but we check for `false`; so we change that. We also use `file_exists()` instead of `Cache::isFileCached()` because the method is actually called `Cache::fileIsCached()` but appears to be broken due to applying `::getCacheablePath()` again. Furthermore the other methods of `Cache` also use `file_exists()` directly. Since `Cache::fileIsCached()` is public, we do not remove the otherwise unused method yet.
Configuration menu - View commit details
-
Copy full SHA for 78c9f7b - Browse repository at this point
Copy the full SHA 78c9f7bView commit details
Commits on Aug 21, 2024
-
Fix php#23: Windows permissions incorrect after cloning (php#24)
We set executable permissions for all .bat and .exe files. This is required for running in Cygwin shells, but generally considered good style.
Configuration menu - View commit details
-
Copy full SHA for 20d13ba - Browse repository at this point
Copy the full SHA 20d13baView commit details
Commits on Aug 25, 2024
-
* Declare methods and instance variables in abstract classes While PHP doesn't require this, it is good style, and makes the code easier to reason about. * Declare class variable While `Config::getSdkNugetFeedUrl()` is not used from within the project, and probably just was some experimental stuff, the method is public, so we better keep it for now, but avoid reading an undeclared class variable. * Dodge from covariance warnings regarding Iterator for now * Don't pass unnecessary arguments These are retrieved from within the called functions, what *might* not be the best idea, but it's what we have for now. * Assert that $cb is actually a string before string conversion In practice, it's either "copy" or "rename". * Declare missing `Server::getPhp()` * Remove unreachable code * Ensure that `$crt` is defined From looking at the code, it seems so, but let's make sure before reading an undefined variable. * Config::getDepsPort() returns an int While that is changing the signature of a public method, it makes no sense to return a string, and later to convert to int again. * The abstract class TrainingCase is an Interfaces\TrainingCase There shouldn't be the need for even having an interface (an abstract class should be sufficient), but we keep the interface for now.
Configuration menu - View commit details
-
Copy full SHA for a047c66 - Browse repository at this point
Copy the full SHA a047c66View commit details -
Some are not as specific as they should be, and some may even be wrong, but since these are only type hints (not type declarations) they won't affect code execution, but rather provide some help to better understand the code – for developers as well as tooling.
Configuration menu - View commit details
-
Copy full SHA for 4b1dbb5 - Browse repository at this point
Copy the full SHA 4b1dbb5View commit details
Commits on Aug 28, 2024
-
Remove out-dated fixme comment
The composer version requirement has long been fixed[1], so we can drop the respective comment also. [1] <php@8583bb4>
Configuration menu - View commit details
-
Copy full SHA for 449a209 - Browse repository at this point
Copy the full SHA 449a209View commit details -
Upgrade bundled PHP to 8.3.9 (phpGH-20)
As of PHP 8.2.0, ext/zip is no longer statically available, but since it is needed by the PHP SDK (e.g. too unpack the fetched dependencies), we include the DLL, and load it in php.ini.
Configuration menu - View commit details
-
Copy full SHA for dc48bef - Browse repository at this point
Copy the full SHA dc48befView commit details
Commits on Sep 3, 2024
-
Update php.ini for PGO for PHP >= 8.2 (phpGH-26)
ext/zip is no longer statically compiled as of PHP 8.2.0, but is needed for several setup tasks; thus we load the shared extension.
Configuration menu - View commit details
-
Copy full SHA for afa44a8 - Browse repository at this point
Copy the full SHA afa44a8View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1cd2c55 - Browse repository at this point
Copy the full SHA 1cd2c55View commit details -
Update Nginx to 1.26.2 (phpGH-28)
That is the latest stable version, and certainly progress over Nginx 1.17.6 which has been released almost five years ago.
Configuration menu - View commit details
-
Copy full SHA for f0b6aac - Browse repository at this point
Copy the full SHA f0b6aacView commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 53d6289 - Browse repository at this point
Copy the full SHA 53d6289View commit details
Commits on Nov 13, 2024
-
Fix HTTP request corruption by the user agent (phpGH-32)
The file `VERSION` used to send the version contains a new line. When it's used to generate the UserAgent for curl, the new line char stops the headers sent for the request. All other headers sent after the user agent are ignored and used like the body requests. To solve this issue, clean up the `VERSION` file content on load.
Configuration menu - View commit details
-
Copy full SHA for b3d87e1 - Browse repository at this point
Copy the full SHA b3d87e1View commit details
Commits on Nov 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 69e50fe - Browse repository at this point
Copy the full SHA 69e50feView commit details
Commits on Dec 19, 2024
-
Replace WMIC with PowerShell for CPU architecture detection (php#40)
- Replace deprecated WMIC command with modern PowerShell - Use Get-CimInstance instead of WMIC to access Win32_Processor - Maintain compatibility with existing code by keeping same output format - Improve compatibility with newer Windows versions - No changes to core program logic We also update to 2.4.0-dev. Closes php#41.
Configuration menu - View commit details
-
Copy full SHA for 311bc6d - Browse repository at this point
Copy the full SHA 311bc6dView commit details
Commits on Feb 5, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 7f8df69 - Browse repository at this point
Copy the full SHA 7f8df69View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master