Skip to content

Improve HTMLCollection and friends #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 17, 2021
Merged

Improve HTMLCollection and friends #599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d1f149
Create HTMLOptionsCollection to improve ux when dealing with <select>…
ghostbuster91 Oct 11, 2021
1b07261
Rewrite HTMLOptionsCollection to extend HTMLCollection
ghostbuster91 Oct 13, 2021
dd4b4af
Parametrize HtmlCollection class with the type of the element
ghostbuster91 Oct 13, 2021
77f33b6
Add HTMLFormControlsCollection, RadioNodeList and remove upper-bound …
ghostbuster91 Oct 15, 2021
568172c
Remove upper-bound type constrain from HTMLCollection type aliases
ghostbuster91 Oct 16, 2021
ea0eb4f
Drop generic type from HTMLCollectionElement to restore bin-compat
ghostbuster91 Oct 16, 2021
00dccef
Regenerate api reports
ghostbuster91 Oct 16, 2021
60a6b59
Merge branch 'master' into HEAD
armanbilge Oct 17, 2021
b4f15a6
Make HTMLCollection covariant in E
armanbilge Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rewrite HTMLOptionsCollection to extend HTMLCollection
  • Loading branch information
@ghostbuster91
ghostbuster91 committed Oct 13, 2021
commit 1b07261ec4d70c4b2146ecab234bad28aa5bb14c
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/HTMLCollection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import scala.scalajs.js.annotation._
*/
@js.native
@JSGlobal
class HTMLCollection private[this] () extends DOMList[Element] {
abstract class HTMLCollection extends DOMList[Element] {
def item(index: Int): Element = js.native

/** Returns the specific node whose ID or, as a fallback, name matches the string specified by name. Matching by name
Expand Down
6 changes: 3 additions & 3 deletions src/main/scala/org/scalajs/dom/HTMLOptionsCollection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ import scala.scalajs.js.annotation._
*/
@js.native
@JSGlobal
class HTMLOptionsCollection private[this] () extends DOMList[HTMLOptionElement] {
def item(index: Int): HTMLOptionElement = js.native
class HTMLOptionsCollection private[this] () extends HTMLCollection {
override def item(index: Int): HTMLOptionElement = js.native

/** Returns the specific node whose ID or, as a fallback, name matches the string specified by name. Matching by name
* is only done as a last resort, only in HTML, and only if the referenced element supports the name attribute.
* Returns null if no node exists by the given name.
*/
def namedItem(name: String): HTMLOptionElement = js.native
override def namedItem(name: String): HTMLOptionElement = js.native
}