Skip to content

Improve HTMLCollection and friends #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 17, 2021
Merged

Improve HTMLCollection and friends #599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d1f149
Create HTMLOptionsCollection to improve ux when dealing with <select>…
ghostbuster91 Oct 11, 2021
1b07261
Rewrite HTMLOptionsCollection to extend HTMLCollection
ghostbuster91 Oct 13, 2021
dd4b4af
Parametrize HtmlCollection class with the type of the element
ghostbuster91 Oct 13, 2021
77f33b6
Add HTMLFormControlsCollection, RadioNodeList and remove upper-bound …
ghostbuster91 Oct 15, 2021
568172c
Remove upper-bound type constrain from HTMLCollection type aliases
ghostbuster91 Oct 16, 2021
ea0eb4f
Drop generic type from HTMLCollectionElement to restore bin-compat
ghostbuster91 Oct 16, 2021
00dccef
Regenerate api reports
ghostbuster91 Oct 16, 2021
60a6b59
Merge branch 'master' into HEAD
armanbilge Oct 17, 2021
b4f15a6
Make HTMLCollection covariant in E
armanbilge Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make HTMLCollection covariant in E
  • Loading branch information
@armanbilge
armanbilge committed Oct 17, 2021
commit b4f15a651120c4d1717d5fca0a0fa0cefd450497
2 changes: 1 addition & 1 deletion api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25826,7 +25826,7 @@ html[SO] type Base = HTMLBaseElement
html[SO] type Body = HTMLBodyElement
html[SO] type Button = HTMLButtonElement
html[SO] type Canvas = HTMLCanvasElement
html[SO] type Collection[E] = HTMLCollection[E]
html[SO] type Collection[+E] = HTMLCollection[E]
html[SO] type DList = HTMLDListElement
html[SO] type DataList = HTMLDataListElement
html[SO] type Div = HTMLDivElement
Expand Down
2 changes: 1 addition & 1 deletion api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25826,7 +25826,7 @@ html[SO] type Base = HTMLBaseElement
html[SO] type Body = HTMLBodyElement
html[SO] type Button = HTMLButtonElement
html[SO] type Canvas = HTMLCanvasElement
html[SO] type Collection[E] = HTMLCollection[E]
html[SO] type Collection[+E] = HTMLCollection[E]
html[SO] type DList = HTMLDListElement
html[SO] type DataList = HTMLDataListElement
html[SO] type Div = HTMLDivElement
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/HTMLCollection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import scala.scalajs.js.annotation._
*/
@js.native
@JSGlobal
abstract class HTMLCollection[E] extends DOMList[E] {
abstract class HTMLCollection[+E] extends DOMList[E] {
def item(index: Int): E = js.native

/** Returns the specific node whose ID or, as a fallback, name matches the string specified by name. Matching by name
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/html.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ object html {
type Button = HTMLButtonElement
type BR = HTMLBRElement
type Canvas = HTMLCanvasElement
type Collection[E] = HTMLCollection[E]
type Collection[+E] = HTMLCollection[E]
type DataList = HTMLDataListElement
type Div = HTMLDivElement
type DList = HTMLDListElement
Expand Down