Skip to content

Minor fixes #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Minor fixes #616

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c819b5
Add deprecated alias for DragEffect
japgolly Oct 21, 2021
9d3f4a6
Add IDBVersionChangeEvent.newVersionOption
japgolly Oct 21, 2021
5a13258
Add IDBDatabase.onclose
japgolly Oct 21, 2021
5c75cb4
Document type parameter S of IDBRequest
japgolly Oct 21, 2021
4de6882
Fix most instances of onerror
japgolly Oct 21, 2021
b4e6fa0
IDB versions are 64-bit, gotta use Double
japgolly Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix most instances of onerror
  • Loading branch information
@japgolly
japgolly committed Oct 21, 2021
commit 4de6882aec3512f04bbf29debc25ef493d33bf15
28 changes: 15 additions & 13 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,7 +1822,7 @@ EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Fu
EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
EventSource[JC] def close(): Unit
EventSource[JC] def dispatchEvent(evt: Event): Boolean
EventSource[JC] var onerror: js.Function1[Event, _]
EventSource[JC] var onerror: js.Function1[ErrorEvent, _]
EventSource[JC] var onmessage: js.Function1[MessageEvent, _]
EventSource[JC] var onopen: js.Function1[Event, _]
EventSource[JC] def readyState: Int
Expand Down Expand Up @@ -3184,7 +3184,7 @@ HTMLBodyElement[JC] var ondrop: js.Function1[DragEvent, _]
HTMLBodyElement[JC] var ondurationchange: js.Function1[Event, _]
HTMLBodyElement[JC] var onemptied: js.Function1[Event, _]
HTMLBodyElement[JC] var onended: js.Function1[Event, _]
HTMLBodyElement[JC] var onerror: js.Function1[Event, _]
HTMLBodyElement[JC] var onerror: js.Function1[ErrorEvent, _]
HTMLBodyElement[JC] var onfocus: js.Function1[FocusEvent, _]
HTMLBodyElement[JC] var onfocusin: js.Function1[FocusEvent, _]
HTMLBodyElement[JC] var onfocusout: js.Function1[FocusEvent, _]
Expand Down Expand Up @@ -4413,7 +4413,7 @@ HTMLDocument[JC] var ondrop: js.Function1[DragEvent, _]
HTMLDocument[JC] var ondurationchange: js.Function1[Event, _]
HTMLDocument[JC] var onemptied: js.Function1[Event, _]
HTMLDocument[JC] var onended: js.Function1[Event, _]
HTMLDocument[JC] var onerror: js.Function1[Event, _]
HTMLDocument[JC] var onerror: js.Function1[ErrorEvent, _]
HTMLDocument[JC] var onfocus: js.Function1[FocusEvent, _]
HTMLDocument[JC] var onfocusin: js.Function1[FocusEvent, _]
HTMLDocument[JC] var onfocusout: js.Function1[FocusEvent, _]
Expand Down Expand Up @@ -14015,7 +14015,7 @@ IDBDatabase[JC] def name: String
IDBDatabase[JC] def objectStoreNames: DOMStringList
IDBDatabase[JC] var onabort: js.Function1[Event, _]
IDBDatabase[JC] var onclose: js.Function1[CloseEvent, _]
IDBDatabase[JC] var onerror: js.Function1[Event, _]
IDBDatabase[JC] var onerror: js.Function1[ErrorEvent, _]
IDBDatabase[JC] var onversionchange: js.Function1[IDBVersionChangeEvent, _]
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
Expand Down Expand Up @@ -14091,7 +14091,7 @@ IDBOpenDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener:
IDBOpenDBRequest[JC] def dispatchEvent(evt: Event): Boolean
IDBOpenDBRequest[JC] def error: DOMException
IDBOpenDBRequest[JC] var onblocked: js.Function1[IDBVersionChangeEvent, _]
IDBOpenDBRequest[JC] var onerror: js.Function1[Event, _]
IDBOpenDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
IDBOpenDBRequest[JC] var onsuccess: js.Function1[IDBEvent[A], _]
IDBOpenDBRequest[JC] var onupgradeneeded: js.Function1[IDBVersionChangeEvent, _]
IDBOpenDBRequest[JC] def readyState: String
Expand All @@ -14104,7 +14104,7 @@ IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Fun
IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
IDBRequest[JC] def dispatchEvent(evt: Event): Boolean
IDBRequest[JC] def error: DOMException
IDBRequest[JC] var onerror: js.Function1[Event, _]
IDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
IDBRequest[JC] var onsuccess: js.Function1[IDBEvent[A], _]
IDBRequest[JC] def readyState: String
IDBRequest[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Expand All @@ -14131,7 +14131,7 @@ IDBTransaction[JC] def mode: IDBTransactionMode
IDBTransaction[JC] def objectStore(name: String): IDBObjectStore
IDBTransaction[JC] var onabort: js.Function1[Event, _]
IDBTransaction[JC] var oncomplete: js.Function1[Event, _]
IDBTransaction[JC] var onerror: js.Function1[Event, _]
IDBTransaction[JC] var onerror: js.Function1[ErrorEvent, _]
IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
IDBTransactionDurability[JT]
Expand Down Expand Up @@ -14159,6 +14159,8 @@ IDBVersionChangeEvent[JC] def target: EventTarget
IDBVersionChangeEvent[JC] override def target: IDBEventTarget[A]
IDBVersionChangeEvent[JC] def timeStamp: Double
IDBVersionChangeEvent[JC] def `type`: String
IDBVersionChangeEvent[SO] def newVersionOption: Option[Int]
IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Int]
IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
Expand Down Expand Up @@ -15170,8 +15172,8 @@ Notification[JC] def dispatchEvent(evt: Event): Boolean
Notification[JC] val icon: String
Notification[JC] val lang: String
Notification[JC] val noscreen: Boolean
Notification[JC] var onclick: js.Function0[Any]
Notification[JC] var onerror: js.Function0[Any]
Notification[JC] var onclick: js.Function1[Event, Any]
Notification[JC] var onerror: js.Function1[ErrorEvent, Any]
Notification[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Notification[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
Notification[JC] val renotify: Boolean
Expand All @@ -15187,15 +15189,15 @@ NotificationOptions[JT] var dir: js.UndefOr[String]
NotificationOptions[JT] var icon: js.UndefOr[String]
NotificationOptions[JT] var lang: js.UndefOr[String]
NotificationOptions[JT] var noscreen: js.UndefOr[Boolean]
NotificationOptions[JT] var onclick: js.UndefOr[js.Function0[Any]]
NotificationOptions[JT] var onerror: js.UndefOr[js.Function0[Any]]
NotificationOptions[JT] var onclick: js.UndefOr[js.Function1[Event, Any]]
NotificationOptions[JT] var onerror: js.UndefOr[js.Function1[ErrorEvent, Any]]
NotificationOptions[JT] var renotify: js.UndefOr[Boolean]
NotificationOptions[JT] var silent: js.UndefOr[Boolean]
NotificationOptions[JT] var sound: js.UndefOr[String]
NotificationOptions[JT] var sticky: js.UndefOr[Boolean]
NotificationOptions[JT] var tag: js.UndefOr[String]
NotificationOptions[JT] var vibrate: js.UndefOr[js.Array[Double]]
NotificationOptions[SO] def apply(body: js.UndefOr[String]?, dir: js.UndefOr[String]?, icon: js.UndefOr[String]?, lang: js.UndefOr[String]?, noscreen: js.UndefOr[Boolean]?, renotify: js.UndefOr[Boolean]?, silent: js.UndefOr[Boolean]?, sound: js.UndefOr[String]?, sticky: js.UndefOr[Boolean]?, tag: js.UndefOr[String]?, onclick: js.UndefOr[js.Function0[Any]]?, onerror: js.UndefOr[js.Function0[Any]]?, vibrate: js.UndefOr[js.Array[Double]]?): NotificationOptions (@deprecated in 2.0.0)
NotificationOptions[SO] def apply(body: js.UndefOr[String]?, dir: js.UndefOr[String]?, icon: js.UndefOr[String]?, lang: js.UndefOr[String]?, noscreen: js.UndefOr[Boolean]?, renotify: js.UndefOr[Boolean]?, silent: js.UndefOr[Boolean]?, sound: js.UndefOr[String]?, sticky: js.UndefOr[Boolean]?, tag: js.UndefOr[String]?, onclick: js.UndefOr[js.Function1[Event, Any]]?, onerror: js.UndefOr[js.Function1[ErrorEvent, Any]]?, vibrate: js.UndefOr[js.Array[Double]]?): NotificationOptions (@deprecated in 2.0.0)
OfflineAudioCompletionEvent[JT] def bubbles: Boolean
OfflineAudioCompletionEvent[JT] def cancelBubble: Boolean
OfflineAudioCompletionEvent[JT] def cancelable: Boolean
Expand Down Expand Up @@ -25010,7 +25012,7 @@ WebSocket[JC] def close(code: Int?, reason: String?): Unit
WebSocket[JC] def dispatchEvent(evt: Event): Boolean
WebSocket[JC] def extensions: String
WebSocket[JC] var onclose: js.Function1[CloseEvent, _]
WebSocket[JC] var onerror: js.Function1[Event, _]
WebSocket[JC] var onerror: js.Function1[ErrorEvent, _]
WebSocket[JC] var onmessage: js.Function1[MessageEvent, _]
WebSocket[JC] var onopen: js.Function1[Event, _]
WebSocket[JC] def readyState: Int
Expand Down
28 changes: 15 additions & 13 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,7 +1822,7 @@ EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Fu
EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
EventSource[JC] def close(): Unit
EventSource[JC] def dispatchEvent(evt: Event): Boolean
EventSource[JC] var onerror: js.Function1[Event, _]
EventSource[JC] var onerror: js.Function1[ErrorEvent, _]
EventSource[JC] var onmessage: js.Function1[MessageEvent, _]
EventSource[JC] var onopen: js.Function1[Event, _]
EventSource[JC] def readyState: Int
Expand Down Expand Up @@ -3184,7 +3184,7 @@ HTMLBodyElement[JC] var ondrop: js.Function1[DragEvent, _]
HTMLBodyElement[JC] var ondurationchange: js.Function1[Event, _]
HTMLBodyElement[JC] var onemptied: js.Function1[Event, _]
HTMLBodyElement[JC] var onended: js.Function1[Event, _]
HTMLBodyElement[JC] var onerror: js.Function1[Event, _]
HTMLBodyElement[JC] var onerror: js.Function1[ErrorEvent, _]
HTMLBodyElement[JC] var onfocus: js.Function1[FocusEvent, _]
HTMLBodyElement[JC] var onfocusin: js.Function1[FocusEvent, _]
HTMLBodyElement[JC] var onfocusout: js.Function1[FocusEvent, _]
Expand Down Expand Up @@ -4413,7 +4413,7 @@ HTMLDocument[JC] var ondrop: js.Function1[DragEvent, _]
HTMLDocument[JC] var ondurationchange: js.Function1[Event, _]
HTMLDocument[JC] var onemptied: js.Function1[Event, _]
HTMLDocument[JC] var onended: js.Function1[Event, _]
HTMLDocument[JC] var onerror: js.Function1[Event, _]
HTMLDocument[JC] var onerror: js.Function1[ErrorEvent, _]
HTMLDocument[JC] var onfocus: js.Function1[FocusEvent, _]
HTMLDocument[JC] var onfocusin: js.Function1[FocusEvent, _]
HTMLDocument[JC] var onfocusout: js.Function1[FocusEvent, _]
Expand Down Expand Up @@ -14015,7 +14015,7 @@ IDBDatabase[JC] def name: String
IDBDatabase[JC] def objectStoreNames: DOMStringList
IDBDatabase[JC] var onabort: js.Function1[Event, _]
IDBDatabase[JC] var onclose: js.Function1[CloseEvent, _]
IDBDatabase[JC] var onerror: js.Function1[Event, _]
IDBDatabase[JC] var onerror: js.Function1[ErrorEvent, _]
IDBDatabase[JC] var onversionchange: js.Function1[IDBVersionChangeEvent, _]
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
Expand Down Expand Up @@ -14091,7 +14091,7 @@ IDBOpenDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener:
IDBOpenDBRequest[JC] def dispatchEvent(evt: Event): Boolean
IDBOpenDBRequest[JC] def error: DOMException
IDBOpenDBRequest[JC] var onblocked: js.Function1[IDBVersionChangeEvent, _]
IDBOpenDBRequest[JC] var onerror: js.Function1[Event, _]
IDBOpenDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
IDBOpenDBRequest[JC] var onsuccess: js.Function1[IDBEvent[A], _]
IDBOpenDBRequest[JC] var onupgradeneeded: js.Function1[IDBVersionChangeEvent, _]
IDBOpenDBRequest[JC] def readyState: String
Expand All @@ -14104,7 +14104,7 @@ IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Fun
IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
IDBRequest[JC] def dispatchEvent(evt: Event): Boolean
IDBRequest[JC] def error: DOMException
IDBRequest[JC] var onerror: js.Function1[Event, _]
IDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
IDBRequest[JC] var onsuccess: js.Function1[IDBEvent[A], _]
IDBRequest[JC] def readyState: String
IDBRequest[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Expand All @@ -14131,7 +14131,7 @@ IDBTransaction[JC] def mode: IDBTransactionMode
IDBTransaction[JC] def objectStore(name: String): IDBObjectStore
IDBTransaction[JC] var onabort: js.Function1[Event, _]
IDBTransaction[JC] var oncomplete: js.Function1[Event, _]
IDBTransaction[JC] var onerror: js.Function1[Event, _]
IDBTransaction[JC] var onerror: js.Function1[ErrorEvent, _]
IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
IDBTransactionDurability[JT]
Expand Down Expand Up @@ -14159,6 +14159,8 @@ IDBVersionChangeEvent[JC] def target: EventTarget
IDBVersionChangeEvent[JC] override def target: IDBEventTarget[A]
IDBVersionChangeEvent[JC] def timeStamp: Double
IDBVersionChangeEvent[JC] def `type`: String
IDBVersionChangeEvent[SO] def newVersionOption: Option[Int]
IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Int]
IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
Expand Down Expand Up @@ -15170,8 +15172,8 @@ Notification[JC] def dispatchEvent(evt: Event): Boolean
Notification[JC] val icon: String
Notification[JC] val lang: String
Notification[JC] val noscreen: Boolean
Notification[JC] var onclick: js.Function0[Any]
Notification[JC] var onerror: js.Function0[Any]
Notification[JC] var onclick: js.Function1[Event, Any]
Notification[JC] var onerror: js.Function1[ErrorEvent, Any]
Notification[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Notification[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
Notification[JC] val renotify: Boolean
Expand All @@ -15187,15 +15189,15 @@ NotificationOptions[JT] var dir: js.UndefOr[String]
NotificationOptions[JT] var icon: js.UndefOr[String]
NotificationOptions[JT] var lang: js.UndefOr[String]
NotificationOptions[JT] var noscreen: js.UndefOr[Boolean]
NotificationOptions[JT] var onclick: js.UndefOr[js.Function0[Any]]
NotificationOptions[JT] var onerror: js.UndefOr[js.Function0[Any]]
NotificationOptions[JT] var onclick: js.UndefOr[js.Function1[Event, Any]]
NotificationOptions[JT] var onerror: js.UndefOr[js.Function1[ErrorEvent, Any]]
NotificationOptions[JT] var renotify: js.UndefOr[Boolean]
NotificationOptions[JT] var silent: js.UndefOr[Boolean]
NotificationOptions[JT] var sound: js.UndefOr[String]
NotificationOptions[JT] var sticky: js.UndefOr[Boolean]
NotificationOptions[JT] var tag: js.UndefOr[String]
NotificationOptions[JT] var vibrate: js.UndefOr[js.Array[Double]]
NotificationOptions[SO] def apply(body: js.UndefOr[String]?, dir: js.UndefOr[String]?, icon: js.UndefOr[String]?, lang: js.UndefOr[String]?, noscreen: js.UndefOr[Boolean]?, renotify: js.UndefOr[Boolean]?, silent: js.UndefOr[Boolean]?, sound: js.UndefOr[String]?, sticky: js.UndefOr[Boolean]?, tag: js.UndefOr[String]?, onclick: js.UndefOr[js.Function0[Any]]?, onerror: js.UndefOr[js.Function0[Any]]?, vibrate: js.UndefOr[js.Array[Double]]?): NotificationOptions (@deprecated in 2.0.0)
NotificationOptions[SO] def apply(body: js.UndefOr[String]?, dir: js.UndefOr[String]?, icon: js.UndefOr[String]?, lang: js.UndefOr[String]?, noscreen: js.UndefOr[Boolean]?, renotify: js.UndefOr[Boolean]?, silent: js.UndefOr[Boolean]?, sound: js.UndefOr[String]?, sticky: js.UndefOr[Boolean]?, tag: js.UndefOr[String]?, onclick: js.UndefOr[js.Function1[Event, Any]]?, onerror: js.UndefOr[js.Function1[ErrorEvent, Any]]?, vibrate: js.UndefOr[js.Array[Double]]?): NotificationOptions (@deprecated in 2.0.0)
OfflineAudioCompletionEvent[JT] def bubbles: Boolean
OfflineAudioCompletionEvent[JT] def cancelBubble: Boolean
OfflineAudioCompletionEvent[JT] def cancelable: Boolean
Expand Down Expand Up @@ -25010,7 +25012,7 @@ WebSocket[JC] def close(code: Int?, reason: String?): Unit
WebSocket[JC] def dispatchEvent(evt: Event): Boolean
WebSocket[JC] def extensions: String
WebSocket[JC] var onclose: js.Function1[CloseEvent, _]
WebSocket[JC] var onerror: js.Function1[Event, _]
WebSocket[JC] var onerror: js.Function1[ErrorEvent, _]
WebSocket[JC] var onmessage: js.Function1[MessageEvent, _]
WebSocket[JC] var onopen: js.Function1[Event, _]
WebSocket[JC] def readyState: Int
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/EventSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class EventSource(URL: String, settings: js.Dynamic = null) extends EventTarget

var onmessage: js.Function1[MessageEvent, _] = js.native

var onerror: js.Function1[Event, _] = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native

/** The close() method must abort any instances of the fetch algorithm started for this EventSource object, and must
* set the readyState attribute to CLOSED. W3C 2012
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/HTMLBodyElement.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ abstract class HTMLBodyElement extends HTMLElement {
* triggered when the event reaches the window, not the body element. Use addEventListener() to attach an event
* listener to the body element.
*/
var onerror: js.Function1[Event, _] = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native

/** Reflects the onresize HTML attribute value for a function to call when the document has been resized. */
var onresize: js.Function1[UIEvent, _] = js.native
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/HTMLDocument.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ abstract class HTMLDocument extends Document {

var onloadedmetadata: js.Function1[Event, _] = js.native

var onerror: js.Function1[Event, _] = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native

var onplay: js.Function1[Event, _] = js.native

Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/IDBDatabase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class IDBDatabase extends EventTarget {
var onclose: js.Function1[CloseEvent, _] = js.native

/** Fires when access to the database fails. */
var onerror: js.Function1[Event, _] = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native

/** Fires when access of the database is aborted. */
var onabort: js.Function1[Event, _] = js.native
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/IDBRequest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class IDBRequest[+S, A] extends EventTarget {
def transaction: IDBTransaction = js.native

/** The event handler for the error event. */
var onerror: js.Function1[Event, _] = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native

/** The state of the request. Every request starts in the pending state. The state changes to done when the request
* completes successfully or when an error occurs.
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/IDBTransaction.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class IDBTransaction extends EventTarget {
def error: DOMException = js.native

/** The event handler for the onerror event. */
var onerror: js.Function1[Event, _] = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native

/** The event handler for the onabort event. */
var onabort: js.Function1[Event, _] = js.native
Expand Down
4 changes: 2 additions & 2 deletions dom/src/main/scala/org/scalajs/dom/Notification.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ class Notification(title: String, options: NotificationOptions = ???) extends Ev
/** The onclick property of the Notification interface specifies an event listener to receive click events. These
* events occur when the user clicks on a displayed Notification.
*/
var onclick: js.Function0[Any] = js.native
var onclick: js.Function1[Event, Any] = js.native

/** The onerror property of the Notification interface specifies an event listener to receive error events. These
* events occur when something goes wrong with a Notification (in many cases an error preventing the notification
* from being displayed.)
*/
var onerror: js.Function0[Any] = js.native
var onerror: js.Function1[ErrorEvent, Any] = js.native

/** The renotify read-only property of the Notification interface specifies whether the user should be notified after
* a new notification replaces an old one, as specified in the renotify option of the Notification() constructor.
Expand Down
Loading