Skip to content

Minor fixes #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Minor fixes #616

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c819b5
Add deprecated alias for DragEffect
japgolly Oct 21, 2021
9d3f4a6
Add IDBVersionChangeEvent.newVersionOption
japgolly Oct 21, 2021
5a13258
Add IDBDatabase.onclose
japgolly Oct 21, 2021
5c75cb4
Document type parameter S of IDBRequest
japgolly Oct 21, 2021
4de6882
Fix most instances of onerror
japgolly Oct 21, 2021
b4e6fa0
IDB versions are 64-bit, gotta use Double
japgolly Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
IDB versions are 64-bit, gotta use Double
  • Loading branch information
@japgolly
japgolly committed Oct 21, 2021
commit b4e6fa0a872de0685292fed0b21cfea8116f7d24
18 changes: 9 additions & 9 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14020,9 +14020,9 @@ IDBDatabase[JC] var onversionchange: js.Function1[IDBVersionChangeEvent, _]
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
IDBDatabase[JC] def transaction(storeNames: String | js.Array[String], mode: js.UndefOr[IDBTransactionMode]?, options: js.UndefOr[IDBTransactionOptions]?): IDBTransaction
IDBDatabase[JC] def version: Int
IDBDatabase[JC] def version: Double
IDBDatabaseInfo[JT] val name: String
IDBDatabaseInfo[JT] val version: Int
IDBDatabaseInfo[JT] val version: Double
IDBEnvironment[JT] def indexedDB: IDBFactory (@deprecated in 1.2.0)
IDBEvent[JC] def bubbles: Boolean
IDBEvent[JC] def cancelBubble: Boolean
Expand All @@ -14047,7 +14047,7 @@ IDBEventTarget[JC] def result: A
IDBFactory[JC] def cmp(first: IDBValue, second: IDBValue): Int
IDBFactory[JC] def databases(): js.Promise[js.Array[IDBDatabaseInfo]]
IDBFactory[JC] def deleteDatabase(name: String): IDBOpenDBRequest[Unit]
IDBFactory[JC] def open(name: String, version: Int?): IDBOpenDBRequest[IDBDatabase]
IDBFactory[JC] def open(name: String, version: Double?): IDBOpenDBRequest[IDBDatabase]
IDBIndex[JC] def count(query: IDBKey | IDBKeyRange?): IDBRequest[S, Double]
IDBIndex[JC] def get(key: IDBKey | IDBKeyRange): IDBRequest[S, IDBValue]
IDBIndex[JC] def getAll(query: js.UndefOr[IDBKeyRange | IDBKey]?, count: js.UndefOr[Double]?): IDBRequest[S, js.Array[IDBValue]]
Expand Down Expand Up @@ -14150,22 +14150,22 @@ IDBVersionChangeEvent[JC] def currentTarget: EventTarget
IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
IDBVersionChangeEvent[JC] def eventPhase: Int
IDBVersionChangeEvent[JC] def isTrusted: Boolean
IDBVersionChangeEvent[JC] def newVersion: Integer
IDBVersionChangeEvent[JC] def oldVersion: Int
IDBVersionChangeEvent[JC] def newVersion: java.lang.Double
IDBVersionChangeEvent[JC] def oldVersion: Double
IDBVersionChangeEvent[JC] def preventDefault(): Unit
IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
IDBVersionChangeEvent[JC] def stopPropagation(): Unit
IDBVersionChangeEvent[JC] def target: EventTarget
IDBVersionChangeEvent[JC] override def target: IDBEventTarget[A]
IDBVersionChangeEvent[JC] def timeStamp: Double
IDBVersionChangeEvent[JC] def `type`: String
IDBVersionChangeEvent[SO] def newVersionOption: Option[Int]
IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Int]
IDBVersionChangeEvent[SO] def newVersionOption: Option[Double]
IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Double]
IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[java.lang.Double]
IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Double]
IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
ImageBitmap[JT] def close(): Unit
ImageBitmap[JT] def height: Double
Expand Down
18 changes: 9 additions & 9 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14020,9 +14020,9 @@ IDBDatabase[JC] var onversionchange: js.Function1[IDBVersionChangeEvent, _]
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
IDBDatabase[JC] def transaction(storeNames: String | js.Array[String], mode: js.UndefOr[IDBTransactionMode]?, options: js.UndefOr[IDBTransactionOptions]?): IDBTransaction
IDBDatabase[JC] def version: Int
IDBDatabase[JC] def version: Double
IDBDatabaseInfo[JT] val name: String
IDBDatabaseInfo[JT] val version: Int
IDBDatabaseInfo[JT] val version: Double
IDBEnvironment[JT] def indexedDB: IDBFactory (@deprecated in 1.2.0)
IDBEvent[JC] def bubbles: Boolean
IDBEvent[JC] def cancelBubble: Boolean
Expand All @@ -14047,7 +14047,7 @@ IDBEventTarget[JC] def result: A
IDBFactory[JC] def cmp(first: IDBValue, second: IDBValue): Int
IDBFactory[JC] def databases(): js.Promise[js.Array[IDBDatabaseInfo]]
IDBFactory[JC] def deleteDatabase(name: String): IDBOpenDBRequest[Unit]
IDBFactory[JC] def open(name: String, version: Int?): IDBOpenDBRequest[IDBDatabase]
IDBFactory[JC] def open(name: String, version: Double?): IDBOpenDBRequest[IDBDatabase]
IDBIndex[JC] def count(query: IDBKey | IDBKeyRange?): IDBRequest[S, Double]
IDBIndex[JC] def get(key: IDBKey | IDBKeyRange): IDBRequest[S, IDBValue]
IDBIndex[JC] def getAll(query: js.UndefOr[IDBKeyRange | IDBKey]?, count: js.UndefOr[Double]?): IDBRequest[S, js.Array[IDBValue]]
Expand Down Expand Up @@ -14150,22 +14150,22 @@ IDBVersionChangeEvent[JC] def currentTarget: EventTarget
IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
IDBVersionChangeEvent[JC] def eventPhase: Int
IDBVersionChangeEvent[JC] def isTrusted: Boolean
IDBVersionChangeEvent[JC] def newVersion: Integer
IDBVersionChangeEvent[JC] def oldVersion: Int
IDBVersionChangeEvent[JC] def newVersion: java.lang.Double
IDBVersionChangeEvent[JC] def oldVersion: Double
IDBVersionChangeEvent[JC] def preventDefault(): Unit
IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
IDBVersionChangeEvent[JC] def stopPropagation(): Unit
IDBVersionChangeEvent[JC] def target: EventTarget
IDBVersionChangeEvent[JC] override def target: IDBEventTarget[A]
IDBVersionChangeEvent[JC] def timeStamp: Double
IDBVersionChangeEvent[JC] def `type`: String
IDBVersionChangeEvent[SO] def newVersionOption: Option[Int]
IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Int]
IDBVersionChangeEvent[SO] def newVersionOption: Option[Double]
IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Double]
IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[java.lang.Double]
IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Double]
IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
ImageBitmap[JT] def close(): Unit
ImageBitmap[JT] def height: Double
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/IDBDatabase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class IDBDatabase extends EventTarget {
* you should use [[IDBVersionChangeEvent#newVersion]] instead. Webkit returns always integer and the value is 1 when
* database is first created.
*/
def version: Int = js.native
def version: Double = js.native

/** A DOMString that contains the name of the connected database. */
def name: String = js.native
Expand Down
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/IDBDatabaseInfo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ import scala.scalajs.js
@js.native
trait IDBDatabaseInfo extends js.Object {
val name: String = js.native
val version: Int = js.native
val version: Double = js.native
}
2 changes: 1 addition & 1 deletion dom/src/main/scala/org/scalajs/dom/IDBFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class IDBFactory extends js.Object {
*
* w3c spec [[http://www.w3.org/TR/IndexedDB/#requests ¶3.2.3 Opening a database]]
*/
def open(name: String, version: Int = js.native): IDBOpenDBRequest[IDBDatabase] = js.native
def open(name: String, version: Double = js.native): IDBOpenDBRequest[IDBDatabase] = js.native

/** Compares two values as keys to determine equality and ordering for IndexedDB operations, such as storing and
* iterating.
Expand Down
10 changes: 5 additions & 5 deletions dom/src/main/scala/org/scalajs/dom/IDBVersionChangeEvent.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ class IDBVersionChangeEvent(typeArg: String, init: js.UndefOr[IDBVersionChangeEv
*
* This is null when the database is being deleted.
*/
def newVersion: Integer = js.native
def newVersion: java.lang.Double = js.native

/** Returns the old version of the database. */
def oldVersion: Int = js.native
def oldVersion: Double = js.native
}

object IDBVersionChangeEvent {
Expand All @@ -35,10 +35,10 @@ object IDBVersionChangeEvent {
*
* This is None when the database is being deleted.
*/
def newVersionOption: Option[Int] =
def newVersionOption: Option[Double] =
(e.newVersion: Any) match {
case i: Int => Some(i)
case _ => None
case i: Double => Some(i)
case _ => None
}
}
}
4 changes: 2 additions & 2 deletions dom/src/main/scala/org/scalajs/dom/IDBVersionChangeEventInit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ package org.scalajs.dom
import scala.scalajs.js

trait IDBVersionChangeEventInit extends EventInit {
var newVersion: js.UndefOr[Integer] = js.undefined
var oldVersion: js.UndefOr[Int] = js.undefined
var newVersion: js.UndefOr[java.lang.Double] = js.undefined
var oldVersion: js.UndefOr[Double] = js.undefined
}