line-directive: Actually stop expanding response files #82028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in swiftlang#81996 fixed the response file format but failed to actually make `line-directive` stop expanding the response files in the compiler invocation. These changes fix that.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
etcwilde
approved these changes
Jun 6, 2025
|
Thanks for the fix! After merging this and https://github.com/swiftlang/swift/pull/81996/files, it looks like some Windows PR test jobs are still failing because of too-long command lines, such as: https://ci-external.swift.org/job/swift-tools-support-core-PR-windows/283/console Are there more places we need this fix? |
|
The new error location looks like it's coming from the new build system which doesn't use line-directive: #82074 moves the availability definitions to a response file, which is where the extra characters came from. |
Steelskin
deleted the
fabrice/line-directive-stop-expanding-response-files
branch
Steelskin
pushed a commit
to Steelskin/swift
that referenced
this pull request
Jun 10, 2025
…ive-stop-expanding-response-files line-directive: Actually stop expanding response files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #81996 fixed the response file format but failed to actually make
line-directivestop expanding the response files in the compiler invocation. These changes fix that.