Shorten command line lengths #82074
Merged
Shorten command line lengths #82074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experimental stdlib runtime build has several sources files, resulting in an absolutely massive commandline. This seems to be approaching, or passing, the maximum command line length on Windows. Switch the Windows build to use a response file generated by CMake to pass the source files to the compiler.
The availability flags keep increasing the number of characters on the command line overflowing the maximum character length on Windows and making the commands harder to read. This patch moves the generated arguments into a separate response file so that they can continue to grow without running into argument length limitations.
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
This was referenced Jun 7, 2025
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Linux |
|
@swift-ci please test Windows |
compnerd
approved these changes
Jun 7, 2025
|
Going to merge this to improve the pass rate on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on shortening up the command line lengths, specifically for Windows.
With the landing of the new availability values, we've leapt over the 32k character limit by about a thousand characters resulting in build failures.
The first patch tells CMake to move source files into a response file. I believe this only takes effect when CMP0157 is enabled, which means that it won't do anything on the Windows CI today since the old Swift driver breaks in that mode. It will shorten things going forward once we have the full swift driver available when building the compiler.
The second patch moves the availability defines to a generated response file.
#81440 doubled the number that we are passing to the compiler, resulting in roughly 2k additional characters being passed on the command line. Prior to this, we were at around 31k, so the 2k put us 1k over the
CreateProcessWlimit.This should fix the Windows CI command line length limit issues for now.