-
Notifications
You must be signed in to change notification settings - Fork 482
feat: add vscode config for ESLint #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,9 +15,12 @@ const featureFlags = [ | |
'vitest', | ||
'cypress', | ||
'playwright', | ||
'nightwatch' | ||
'nightwatch', | ||
'eslint', | ||
'eslint-with-prettier' | ||
] | ||
const featureFlagsDenylist = [ | ||
['eslint', 'eslint-with-prettier'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the changes to this file should be removed, as this is going to generate a lot of new snapshots (that's why they aren't generated at the moment). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved eslint and eslint-with-prettier as separate features based on #460 (comment). |
||
['cypress', 'playwright'], | ||
['playwright', 'nightwatch'], | ||
['cypress', 'nightwatch'], | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"recommendations": ["dbaeumer.vscode-eslint"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"editor.codeActionsOnSave": { | ||
"source.fixAll": "explicit" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍