drivers: spi: introduce basic spi driver for wch #90243
Conversation
|
Only tested on ch32v203 for now, will test more later. |
drivers/spi/spi_wch.c
Outdated
|
|
||
| struct spi_wch_config { | ||
| SPI_TypeDef *regs; | ||
| const struct pinctrl_dev_config *pcfg; |
There was a problem hiding this comment.
nit: for consistency with the other WCH drivers, call this 'pin_cfg'.
drivers/spi/spi_wch.c
Outdated
| SPI_TypeDef *regs; | ||
| const struct pinctrl_dev_config *pcfg; | ||
| const struct device *clk_dev; | ||
| uint8_t clk_id; |
There was a problem hiding this comment.
nit: s/clk_id/clock_id/
drivers/spi/spi_wch.c
Outdated
|
|
||
| #include <ch32fun.h> | ||
|
|
||
| #define SPI_CTLR1_LSBFIRST ((uint16_t)0x0080) |
There was a problem hiding this comment.
nit: Zephyr style seems to be to use BIT(7).
drivers/spi/spi_wch.c
Outdated
| uint8_t div = 0; | ||
| int div_val = 2; | ||
|
|
||
| for (;div < 8; div++) { |
There was a problem hiding this comment.
nit: use for (div = 0; div < 8; div++) so the initialisation is next to the first use.
drivers/spi/spi_wch.c
Outdated
| } | ||
| div_val *= 2; | ||
| } | ||
| return div; |
There was a problem hiding this comment.
nit: blank line before
drivers/spi/spi_wch.c
Outdated
| spi_context_cs_control(&data->ctx, true); | ||
|
|
||
| /* Start SPI *AFTER* setting CS */ | ||
| cfg->regs->CTLR1 |= SPI_CTLR1_SPE; |
There was a problem hiding this comment.
Add a SPI_Typedef *regs = cfg->regs above and use it everywhere.
drivers/spi/spi_wch.c
Outdated
| while (spi_context_tx_on(&data->ctx) || spi_context_rx_on(&data->ctx)) { | ||
| if (spi_context_tx_buf_on(&data->ctx)) { | ||
| cfg->regs->DATAR = *(uint8_t *)(data->ctx.tx_buf); | ||
| while(!(cfg->regs->STATR & SPI_STATR_TXE)) {} |
There was a problem hiding this comment.
For consistency, use while ((regs->STATR & SPI_START_TXE) != 0U) { }
There was a problem hiding this comment.
not quite... more like while ((regs->STATR & SPI_START_TXE) == 0U) { }
drivers/spi/spi_wch.c
Outdated
| cfg->regs->DATAR = *(uint8_t *)(data->ctx.tx_buf); | ||
| while(!(cfg->regs->STATR & SPI_STATR_TXE)) {} | ||
| } else { | ||
| cfg->regs->DATAR = 0; |
There was a problem hiding this comment.
I'm pretty sure this should still wait for TXE before writing, even if it's writing a zero.
drivers/spi/spi_wch.c
Outdated
| cfg->regs->DATAR = 0; | ||
| } | ||
| spi_context_update_tx(&data->ctx, 1, 1); | ||
| while(!(cfg->regs->STATR & SPI_STATR_RXNE)) {} |
There was a problem hiding this comment.
ditto re: testing for a flag.
VynDragon
force-pushed
the
wch_spi
branch
3 times, most recently
from
9f91fc2 to
692cf58
Compare
github-actions
bot
added
platform: WinChipHead
area: SPI
github-actions
bot
requested review from
carlocaione,
edersondisouza,
fkokosinski,
gmarull,
katsuster,
kgugala,
mgielda,
npitre,
tbursztyka,
teburd,
tgorochowik and
ycsin
|
(all changes you suggested were done @nzmichaelh) |
|
CH32V00x pinctrl for SPI looks very wrong |
|
Tested working on ch32v006 with st7567 so ill assume it works on everything else. |
dts/riscv/wch/ch32v203/ch32v203.dtsi
Outdated
|
|
||
| spi2: spi@40003800 { | ||
| compatible = "wch,spi"; | ||
| reg = <40003800 0x24>; |
There was a problem hiding this comment.
| reg = <40003800 0x24>; | |
| reg = <0x40003800 0x24>; |
introduces a basic SPI driver for CH32 series Signed-off-by: Camille BAUD <[email protected]>
This fixes incorrect/incomplete pinctrl for CH32V006 Signed-off-by: Camille BAUD <[email protected]>
|
introduces a basic SPI driver for CH32 series