[Backport v4.0-branch] drivers: i2c: stm32: add timeout to avoid infinite loop #90660
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fix issue where STM32 I2C LL driver could block forever when SDA and SCL are shorted and interrupts are disabled (CONFIG_I2C_STM32_INTERRUPT=n). Added timeouts to all blocking wait loops in the STM32 LL I2C driver to avoid indefinite blocking. Fixes #88506 Signed-off-by: Jean Nanchen <[email protected]> (cherry picked from commit 2066b8c)
|
ydamigos
approved these changes
May 28, 2025
JarmouniA
approved these changes
Jun 24, 2025
JarmouniA
requested changes
Jun 24, 2025
| @@ -1181,5 +1201,26 @@ int stm32_i2c_transaction(const struct device *dev, | |||
| msg.len = rest; | |||
| } while (rest > 0U); | |||
|
|
|||
| #ifndef CONFIG_I2C_STM32_INTERRUPT | |||
| struct i2c_stm32_data *data = dev->data; | |||
|
|
|||
There was a problem hiding this comment.
missing
Suggested change
| const struct i2c_stm32_config *cfg = dev->config; | |
| I2C_TypeDef *i2c = cfg->i2c; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2066b8c from #88631.