Skip to content

samples: enable build tests for the ch32v006evt #90690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nzmichaelh
Copy link
Collaborator

The ch32v006evt has 8 KiB of RAM which is enough for many of the basic samples but, by default, Twister assumes that a sample needs 16 KiB of RAM.

Mark some of the samples as needing 8 KiB of RAM so the ch32v006evt gets better CI coverage.

@nzmichaelh
Copy link
Collaborator Author

Note that Twister should fail at the moment, but then pass once #90438 is merged and I rebase.

@nzmichaelh nzmichaelh marked this pull request as ready for review May 27, 2025 18:46
@github-actions github-actions bot added area: Samples Samples area: LED Label to identify LED subsystem area: Watchdog Watchdog labels May 27, 2025
@nzmichaelh
Copy link
Collaborator Author

Hmm, Twister ran: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15291782992/job/43012659289?pr=90690

but the results don't include the ch32v006evt, but do pass for boards like gd32e103v_eval, frdm_k22f. I'll investigate as I suspect there's a default platform list.

@kartben
Copy link
Collaborator

kartben commented May 28, 2025

Hmm, Twister ran: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15291782992/job/43012659289?pr=90690

but the results don't include the ch32v006evt, but do pass for boards like gd32e103v_eval, frdm_k22f. I'll investigate as I suspect there's a default platform list.

Twister only runs on integration_platforms: on pull requests and when push to main (i.e. merge). It's only in the weekly CI run that the rest of the platforms are included.

@nzmichaelh
Copy link
Collaborator Author

Hmm, Twister ran: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15291782992/job/43012659289?pr=90690
but the results don't include the ch32v006evt, but do pass for boards like gd32e103v_eval, frdm_k22f. I'll investigate as I suspect there's a default platform list.

Twister only runs on integration_platforms: on pull requests and when push to main (i.e. merge). It's only in the weekly CI run that the rest of the platforms are included.

Thanks. Still sounds worthwhile then, and the developer can do a twister --vendor wch manually.

@kartben
Copy link
Collaborator

kartben commented Jun 6, 2025

I'm fine with the change but the commit message is off -- it should simply refer to the fact you're lowering the min RAM requirements

The ch32v006evt has 8 KiB of RAM which is enough for many of the basic
samples but, by default, Twister assumes that a sample needs 16 KiB
of RAM.

Mark some of the samples as needing 8 KiB of RAM so the ch32v006evt
gets better CI coverage.

Signed-off-by: Michael Hope <[email protected]>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LED Label to identify LED subsystem area: Samples Samples area: Watchdog Watchdog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants