Hi
On 7/21/24 00:16, Larry Garfield wrote:
Yes, any syntax change means tools need to adapt, but that doesn't mean tokenization can change randomly and accidentally. Syntax changes require an RFC. If an RFC passes that necessitates SA tools update, so be it. (That happens almost every version.) But that's still an RFC change.
I would agree with reverting this change for now. The odds of it breaking something for someone are vanishingly small, and it's a bug, not a feature. If we want it to be a feature, we can make an RFC for it.
It has become a feature no later than November, 23rd, 2023, when PHP 8.3.0 has been released.
There is no bug, token_get_all() still is working within its specification.
We can't just break backwards compatibility with well-formed PHP scripts when it causes an inconvenience for tool authors and at the same time bend over backwards with an impact analysis to find out if the deprecation (not removal!) of a property that literally always is null would be too much of a backwards compatibility impact.
The PHP users writing PHP scripts accepted by PHP 8.3 and visually fitting into PHP’s syntax with regard to comment placement are not at fault here and shouldn't bear the consequences.
Best regards
Tim Düsterhus