Re: Add tidyNode::getNextSibling() and tidyNode::getPreviousSibling()

From: Date: Sun, 21 Jul 2024 14:51:33 +0000
Subject: Re: Add tidyNode::getNextSibling() and tidyNode::getPreviousSibling()
References: 1  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
On Sunday, 21 July 2024 at 12:24, Niels Dossche <[email protected]> wrote:

> Hi internals
> 
> I opened a PR to add the getNextSibling() and getPreviousSibling() methods to the tidyNode
> class.
> As the class is final, this has no BC break concerns.
> 
> The reason for adding this is that it's inconvenient to walk the tree solely using the
> existing getParent() method and ->child property.
> 
> Since it's a tree anyway, methods to obtain the previous or next sibling are natural en
> convenient.
> 
> Just sending this mail to see if anyone objects to this.
> PR link: https://github.com/php/php-src/pull/15047
> 
> Kind regards
> Niels

I think this makes sense and is a nice convenience addition.

Best regards,

Gina P. Banyard

Thread (2 messages)

« previous php.internals (#124536) next »