Re: Adieu register_globals

From: Date: Sun, 05 Mar 2006 15:31:05 +0000
Subject: Re: Adieu register_globals
References: 1  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hello Pierre,

Sunday, March 5, 2006, 4:21:28 PM, you wrote:

> Hello,

> As discussed last year, register_globals will be removed in php6. This
> patch is the first step:

> http://pear.php.net/~pierre/remove_register_globals.txt

> The only thing I find confusing is a comment in main/php_variables.c
> php_autoglobal_merge. The comment says something and the tests
> something else (register_globals AND instead of register_globals OR). I
> will review all the affected tests if you consider this patch ok to be
> commited. Some will be updated, other simply removed.

> I did not run benchmarks, but I feel like it speeds up php a bit :)

I see the same.

> Comments and feedbacks welcome,

"Wipe them out - *all* of them" just as discussed. But take care of the
tests first.

Best regards,
 Marcus


Thread (25 messages)

« previous php.internals (#22123) next »