Re: Re: Adieu register_globals

From: Date: Tue, 07 Mar 2006 14:08:41 +0000
Subject: Re: Re: Adieu register_globals
References: 1 2 3 4 5 6 7 8  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
At 12:27 07/03/2006, Pierre wrote:

On 3/7/06, Derick Rethans <[email protected]> wrote:
On Tue, 7 Mar 2006, Stefan Esser wrote:




That was the plan.  Checking for register_globals should return
false.


Pierre's list says it removes things like
get_magic_quotes_gpc() ..., which is a NONO.


yeah, agreed. And we should also throw errors when people make the
setting, as per
http://www.php.net/~derick/meeting-notes.html#register-globals

What is the point of detecting something that does not exist anymore?


The point is that breakage is aggregated, not binary.  The more stuff we break, the more difficult it is to port, and frankly, it's quite likely that a non OO app could migrate fairly cleanly even to PHP 6 with unicode disabled (perhaps with minor fixes).  get_magic_quotes_gpc() is designed for apps to do something differently depending on the value of magic_quotes_gpc.  It's fine that it's always off in PHP 6, but there's no reason not to keep this function (to always return false) so that you don't have to fix God knows how many lines of code to remove it.

Zeev

Thread (25 messages)

« previous php.internals (#22193) next »