Re: Stop Breaking Our Apps For the Sake of OO

From: Date: Thu, 11 May 2006 14:22:36 +0000
Subject: Re: Stop Breaking Our Apps For the Sake of OO
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
Pierre wrote:

On Thu, 11 May 2006 14:15:53 +0200 (CEST)
[email protected] (Derick Rethans) wrote:


Hello!

While I welcome new developments in either procedural or OO
interfaces in PHP I do not agree with breaking BC (between 5.1 and
5.2 in this case) just for the sake of OO purity. In this example
there is the following class:


I forgot to mention how vicious such changes can be. Most of times the
related tests are "updated" in the same commit (or right after) to
follow the new behavior. Making nearly impossible to know about the
breakages without duplicating core tests in our apps. Also commit
messages or changelog entries are rarely explicit enough to mention
them.


Yeah, modifications that require changes to existing tests due to BC breakage should get a clear label in the NEWS file that makes it clear that its a BC break. Otherwise things slip through the radar unnoticed or the scope of the change is never put to discussion.

regards,
Lukas

Thread (33 messages)

« previous php.internals (#23249) next »