Re: Re: svn: /php/php-src/ branches/PHP_5_4/main/output.c trunk/main/output.c

From: Date: Wed, 15 Feb 2012 09:16:52 +0000
Subject: Re: Re: svn: /php/php-src/ branches/PHP_5_4/main/output.c trunk/main/output.c
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
On Wed, 15 Feb 2012 10:07:50 +0100, Michael Wallner <[email protected]> wrote:


On Tue, 14 Feb 2012 12:50:40 -0800, Christopher Jones wrote:


It would be great to have a NEWS entry and a testcase and a bug number.



Definitely.

Seriously, there's no code in core using it, so there's no test case.
...and it's been reported on internals@ not bugs.php.net, so there's no
bug number.
So, after all it doesn't seem to warrant a NEWS entry, does it?



A test case would be difficult (though if you thought it was really necessary you could add some code limited to debug builds), but I don't see how it having been reported on internals@ prevents a NEWS entry. Even not considering the fact you could open a bug to track the issue, there have been plenty of news entries without corresponding bug numbers.

As far as I know, if the change is user visible -- and in this case it appears to be (namely old output handlers will now work) --, then it should be in NEWS.

-- 
Gustavo Lopes

Thread (7 messages)

« previous php.internals (#57882) next »