Re: Re: svn: /php/php-src/ branches/PHP_5_4/main/output.c trunk/main/output.c

From: Date: Wed, 15 Feb 2012 15:09:15 +0000
Subject: Re: Re: svn: /php/php-src/ branches/PHP_5_4/main/output.c trunk/main/output.c
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message


On Feb 15, 2012, at 1:07 AM, Michael Wallner <[email protected]> wrote:

> On Tue, 14 Feb 2012 12:50:40 -0800, Christopher Jones wrote:
> 
>> It would be great to have a NEWS entry and a testcase and a bug number.
>> 
> 
> Definitely.
> 
> Seriously, there's no code in core using it, so there's no test case.
> ...and it's been reported on internals@ not bugs.php.net, so there's no 
> bug number.
> So, after all it doesn't seem to warrant a NEWS entry, does it?
> 


Of course it warrants a NEWS entry.  Unless no one in the world was using it (in which case why have
any code there?), a news entry will help explain a behavior difference, or identify when something
broke (if you just accidentally broke something) that someone could be interested in.

Chris


>> 
>> On 02/14/2012 11:31 AM, Michael Wallner wrote:
>>> mike                                     Tue, 14 Feb 2012 19:31:54
>>> +0000
>>> 
>>> Revision: http://svn.php.net/viewvc?view=revision&revision=323219
>>> 
>>> Log:
>>> fix compat function not passing along input buffer with
>>> php_output_context_pass() if the output_handler_func does not set
>>> out_str
> 
> Cheers,
> Mike
> 
> 
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 


Thread (7 messages)

« previous php.internals (#57883) next »