Re: Github Pull Request
thanks dsp and johannes for this nice tool.
On Tue, Mar 20, 2012 at 10:16 AM, David Soria Parra <[email protected]> wrote:
> Hi
>
> with the php-src migrated to git we start receiving
> pull request on github. A few things to notice:
>
> - developers can pull the requests as described here:
> https://wiki.php.net/vcs/gitfaq#github_pull_requests
> - people with valid github accounts can comment
> on pull request
> - people with valid php accounts can close pull
> request using the tool http://qa.php.net/pulls.
> Thank you joahnnes for writing it.
>
> Before pulling make sure:
>
> - the pull request contains appropriate tests for
> the change
> - the commit message contains a good and precise
> description what was changed and why
>
> ensure that you pull it into the right branch.
>
> Pull request notifications are send to the
> [email protected] mailinglist.
>
> Note that we DONT hand out access to the
> github repository and will we not add
> you to the PHP organization on github.
>
> - David
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
Thread (19 messages)